fixes

oscar-system · Feb 13, 2024 · 87fceac · 87fceac
1 parent f8d585d
commit 87fceac
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Groups/sub.jl b/src/Groups/sub.jl
@@ -558,8 +558,8 @@ function is_maximal_subgroup(H::T, G::T; check::Bool = true) where T <: GAPGroup
   is_prime(ind) && return true
   if ind < 100
     # Do not unpack the right transversal object.
-    t = right_transversal(G, H)[2:end] #drop the identity
-    return all(i -> order(sub(G, vcat(gens(H), [t[i]]))[1]) == order(G), 2:ind)
+    t = right_transversal(G, H)
+    return all(i -> order(sub(G, vcat(gens(H), [t[i]]))[1]) == order(G), 2:Int(ind))
   end
   return any(C -> H in C, maximal_subgroup_classes(G))
 end

diff --git a/test/Groups/conjugation.jl b/test/Groups/conjugation.jl
@@ -109,8 +109,8 @@
   G = symmetric_group(5)
   CC = @inferred maximal_subgroup_classes(G)
   @test all(H -> degree(H) == degree(G), map(representative, CC))
-  @test all(H -> is_maximal_subgroup(G, H), map(representative, CC))
-  @test !is_maximal_subgroup(G, trivial_subgroup(G)[1])
+  @test all(H -> is_maximal_subgroup(H, G), map(representative, CC))
+  @test !is_maximal_subgroup(trivial_subgroup(G)[1], G)
 
   G = symmetric_group(10)
   x = rand(G)