Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add permutation action on FreeAssAlgElems #2792

Merged
merged 1 commit into from
Sep 15, 2023
Merged

add permutation action on FreeAssAlgElems #2792

merged 1 commit into from
Sep 15, 2023

Conversation

ThomasBreuer
Copy link
Member

(can be merged as soon as Nemocas/AbstractAlgebra.jl/pull/1418 is available in Oscar)

@thofma thofma closed this Sep 15, 2023
@thofma thofma reopened this Sep 15, 2023
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #2792 (e77397e) into master (f6253d7) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2792      +/-   ##
==========================================
- Coverage   73.60%   73.56%   -0.04%     
==========================================
  Files         455      455              
  Lines       64514    64523       +9     
==========================================
- Hits        47483    47467      -16     
- Misses      17031    17056      +25     
Files Changed Coverage
src/Groups/action.jl 0.00%

@thofma
Copy link
Collaborator

thofma commented Sep 15, 2023

I wonder whats up with coverage.

@ThomasBreuer
Copy link
Member Author

The failures look different than earlier ones (where either the job got canceled or some specific error was shown). How can I interpret the current failures?

@benlorenz
Copy link
Member

I wonder whats up with coverage.

Report is 62 commits behind head on master.
The diff coverage is 0.00%.

This seems to be comparing a pretty old commit from master (base commit of this branch, 16 days ago) with the merge commit from this branch with master (since CI runs on a temporary merge)?

@benlorenz
Copy link
Member

The failures look different than earlier ones (where either the job got canceled or some specific error was shown). How can I interpret the current failures?

Sometimes it helps to use View raw logs, but in this case one of those also doesn't work. The failures for 1.10 and nightly on ubuntu can be ignored and are caused by the usual OOM issues.

@thofma
Copy link
Collaborator

thofma commented Sep 15, 2023

Let's see if a rebase fixes the coverage

@thofma
Copy link
Collaborator

thofma commented Sep 15, 2023

Still not working, no clue why

@thofma thofma enabled auto-merge (squash) September 15, 2023 13:22
@thofma thofma enabled auto-merge (squash) September 15, 2023 13:22
@thofma thofma merged commit 6f2c6e0 into oscar-system:master Sep 15, 2023
13 of 15 checks passed
benlorenz added a commit that referenced this pull request Sep 15, 2023
thofma pushed a commit that referenced this pull request Sep 15, 2023
@ThomasBreuer ThomasBreuer deleted the TB_free_ass_alg_action branch September 18, 2023 20:22
fieker pushed a commit that referenced this pull request Sep 29, 2023
fieker pushed a commit that referenced this pull request Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants