-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect our serialization with Julia serialization #2837
Conversation
This was merged in Hecke thofma/Hecke.jl#1219 |
There is already a new version. I have restarted CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seemed OK on a quick look, let's merge and refine later
Codecov Report
@@ Coverage Diff @@
## master #2837 +/- ##
==========================================
+ Coverage 80.62% 80.68% +0.06%
==========================================
Files 456 456
Lines 64703 69619 +4916
==========================================
+ Hits 52166 56175 +4009
- Misses 12537 13444 +907
|
Minimal working example of distributed processing in oscar.
Needs thofma/Hecke.jl#1219 before merge due to conflicting
serialize methods.
Extends serialize for Oscar types that aren't julia types. Introduces two Oscar serializer types
The JSONSerializer is how the serialization in Oscar has ben used so far. The IPCSerializer
aims at being efficient by not sending the refs, which then leaves it up to the user
to guarantee that the appropriate refs are sent to processes that need them.
See included test for an example.