Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Hecke version #2838

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Bump Hecke version #2838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ AbstractAlgebra = "0.32.1"
AlgebraicSolving = "0.3.3"
DocStringExtensions = "0.8, 0.9"
GAP = "0.9.4"
Hecke = "0.21"
Hecke = "0.22"
JSON = "^0.20, ^0.21"
Nemo = "0.36"
Polymake = "0.11.1"
Expand Down
3 changes: 1 addition & 2 deletions experimental/PlaneCurve/src/PlaneCurve.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,8 +469,7 @@ julia> C = AffinePlaneCurve(y^2+x-x^3)
Affine plane curve defined by -x^3 + x + y^2

julia> Oscar.ring(C)
(Quotient of multivariate polynomial ring by ideal(-x^3 + x + y^2), Map from
Multivariate polynomial ring in 2 variables over QQ to Quotient of multivariate polynomial ring by ideal(-x^3 + x + y^2) defined by a julia-function with inverse)
(Quotient of multivariate polynomial ring by ideal(-x^3 + x + y^2), Map: multivariate polynomial ring -> quotient of multivariate polynomial ring)
```
"""
function ring(C::PlaneCurve)
Expand Down
9 changes: 3 additions & 6 deletions experimental/Schemes/duValSing.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ julia> I = ideal(R,[w,x^2+y^3+z^4])
ideal(w, x^2 + y^3 + z^4)

julia> Rq,_ = quo(R,I)
(Quotient of multivariate polynomial ring by ideal(w, x^2 + y^3 + z^4), Map from
Multivariate polynomial ring in 4 variables over QQ to Rq defined by a julia-function with inverse)
(Quotient of multivariate polynomial ring by ideal(w, x^2 + y^3 + z^4), Map: multivariate polynomial ring -> quotient of multivariate polynomial ring)

julia> X = Spec(Rq)
Spectrum
Expand Down Expand Up @@ -75,8 +74,7 @@ julia> I = ideal(R,[w,x^2+y^3+z^4])
ideal(w, x^2 + y^3 + z^4)

julia> Rq,_ = quo(R,I)
(Quotient of multivariate polynomial ring by ideal(w, x^2 + y^3 + z^4), Map from
Multivariate polynomial ring in 4 variables over QQ to Rq defined by a julia-function with inverse)
(Quotient of multivariate polynomial ring by ideal(w, x^2 + y^3 + z^4), Map: multivariate polynomial ring -> quotient of multivariate polynomial ring)

julia> J = ideal(R,[x,y,z,w])
ideal(x, y, z, w)
Expand Down Expand Up @@ -150,8 +148,7 @@ julia> I = ideal(R,[w,x^2+y^3+z^4])
ideal(w, x^2 + y^3 + z^4)

julia> Rq,_ = quo(R,I)
(Quotient of multivariate polynomial ring by ideal(w, x^2 + y^3 + z^4), Map from
Multivariate polynomial ring in 4 variables over QQ to Rq defined by a julia-function with inverse)
(Quotient of multivariate polynomial ring by ideal(w, x^2 + y^3 + z^4), Map: multivariate polynomial ring -> quotient of multivariate polynomial ring)

julia> J = ideal(R,[x,y,z,w])
ideal(x, y, z, w)
Expand Down
6 changes: 2 additions & 4 deletions src/Combinatorics/SimplicialComplexes.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,8 +305,7 @@ Return the Stanley-Reisner ring of the abstract simplicial complex `K`.
julia> K = SimplicialComplex([[1,2,3],[2,3,4]]);

julia> stanley_reisner_ring(K)
(Quotient of multivariate polynomial ring by ideal(x1*x4), Map from
Multivariate polynomial ring in 4 variables over QQ to Quotient of multivariate polynomial ring by ideal(x1*x4) defined by a julia-function with inverse)
(Quotient of multivariate polynomial ring by ideal(x1*x4), Map: multivariate polynomial ring -> quotient of multivariate polynomial ring)
```
"""
function stanley_reisner_ring(K::SimplicialComplex)
Expand All @@ -325,8 +324,7 @@ Return the Stanley-Reisner ring of the abstract simplicial complex `K`, as a quo
julia> R, _ = ZZ["a","b","c","d","e","f"];

julia> stanley_reisner_ring(R, real_projective_plane())
(Quotient of multivariate polynomial ring by ideal(a*b*c, a*b*d, a*e*f, b*e*f, a*c*f, a*d*e, c*d*e, c*d*f, b*c*e, b*d*f), Map from
Multivariate polynomial ring in 6 variables over ZZ to Quotient of multivariate polynomial ring by ideal(a*b*c, a*b*d, a*e*f, b*e*f, a*c*f, a*d*e, c*d*e, c*d*f, b*c*e, b*d*f) defined by a julia-function with inverse)
(Quotient of multivariate polynomial ring by ideal(a*b*c, a*b*d, a*e*f, b*e*f, a*c*f, a*d*e, c*d*e, c*d*f, b*c*e, b*d*f), Map: multivariate polynomial ring -> quotient of multivariate polynomial ring)
```
"""
stanley_reisner_ring(R::MPolyRing, K::SimplicialComplex) = quo(R, stanley_reisner_ideal(R, K))
Expand Down
3 changes: 1 addition & 2 deletions src/Modules/ModulesGraded.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,8 +240,7 @@ julia> R, (x, y) = graded_polynomial_ring(QQ, ["x", "y"])
(Graded multivariate polynomial ring in 2 variables over QQ, MPolyDecRingElem{QQFieldElem, QQMPolyRingElem}[x, y])

julia> S, _ = quo(R, [x*y])
(Quotient of multivariate polynomial ring by ideal(x*y), Map from
R to S defined by a julia-function with inverse)
(Quotient of multivariate polynomial ring by ideal(x*y), Map: graded multivariate polynomial ring -> quotient of multivariate polynomial ring)

julia> F = free_module(S, 2)
Free module of rank 2 over S
Expand Down
6 changes: 2 additions & 4 deletions src/Modules/UngradedModules.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5570,8 +5570,7 @@ julia> F2 = free_module(R, 2)
Free module of rank 2 over Multivariate polynomial ring in 3 variables over QQ

julia> V, f = hom(F1, F2)
(hom of (F1, F2), Map from
V to Set of all homomorphisms from Free module of rank 3 over Multivariate polynomial ring in 3 variables over QQ to Free module of rank 2 over Multivariate polynomial ring in 3 variables over QQ defined by a julia-function with inverse)
(hom of (F1, F2), Map: hom of (F1, F2) -> set of all homomorphisms from Free module of rank 3 over Multivariate polynomial ring in 3 variables over QQ to Free module of rank 2 over Multivariate polynomial ring in 3 variables over QQ)

julia> f(V[1])
Map with following data
Expand All @@ -5598,8 +5597,7 @@ julia> F2 = graded_free_module(Rg, [3,5])
Graded free module Rg^1([-3]) + Rg^1([-5]) of rank 2 over Rg

julia> V, f = hom(F1, F2)
(hom of (F1, F2), Map from
V to Set of all homomorphisms from Graded free module Rg^1([-1]) + Rg^2([-2]) of rank 3 over Rg to Graded free module Rg^1([-3]) + Rg^1([-5]) of rank 2 over Rg defined by a julia-function with inverse)
(hom of (F1, F2), Map: hom of (F1, F2) -> set of all homomorphisms from Graded free module Rg^1([-1]) + Rg^2([-2]) of rank 3 over Rg to Graded free module Rg^1([-3]) + Rg^1([-5]) of rank 2 over Rg)

julia> f(V[1])
F1 -> F2
Expand Down
43 changes: 22 additions & 21 deletions src/Rings/MPolyQuo.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,8 +213,7 @@ julia> R, (x, y, z) = polynomial_ring(QQ, ["x", "y", "z"])
(Multivariate polynomial ring in 3 variables over QQ, QQMPolyRingElem[x, y, z])

julia> A, _ = quo(R, ideal(R, [y-x^2, z-x^3]))
(Quotient of multivariate polynomial ring by ideal(-x^2 + y, -x^3 + z), Map from
Multivariate polynomial ring in 3 variables over QQ to A defined by a julia-function with inverse)
(Quotient of multivariate polynomial ring by ideal(-x^2 + y, -x^3 + z), Map: multivariate polynomial ring -> quotient of multivariate polynomial ring)

julia> a = ideal(A, [x-y])
ideal(x - y)
Expand Down Expand Up @@ -243,8 +242,7 @@ julia> R, (x, y, z) = polynomial_ring(QQ, ["x", "y", "z"])
(Multivariate polynomial ring in 3 variables over QQ, QQMPolyRingElem[x, y, z])

julia> A, _ = quo(R, ideal(R, [y-x^2, z-x^3]))
(Quotient of multivariate polynomial ring by ideal(-x^2 + y, -x^3 + z), Map from
Multivariate polynomial ring in 3 variables over QQ to A defined by a julia-function with inverse)
(Quotient of multivariate polynomial ring by ideal(-x^2 + y, -x^3 + z), Map: multivariate polynomial ring -> quotient of multivariate polynomial ring)

julia> a = ideal(A, [x-y])
ideal(x - y)
Expand Down Expand Up @@ -845,8 +843,9 @@ julia> typeof(x)
QQMPolyRingElem

julia> p
Map from
Multivariate polynomial ring in 2 variables over QQ to A defined by a julia-function with inverse
Map defined by a julia-function with inverse
from multivariate polynomial ring in 2 variables over QQ
to quotient of multivariate polynomial ring by ideal(x^2 - y^3, x - y)

julia> p(x)
x
Expand All @@ -858,8 +857,7 @@ MPolyQuoRingElem{QQMPolyRingElem}
julia> S, (x, y, z) = graded_polynomial_ring(QQ, ["x", "y", "z"]);

julia> B, _ = quo(S, ideal(S, [x^2*z-y^3, x-y]))
(Quotient of multivariate polynomial ring by ideal(x^2*z - y^3, x - y), Map from
S to B defined by a julia-function with inverse)
(Quotient of multivariate polynomial ring by ideal(x^2*z - y^3, x - y), Map: graded multivariate polynomial ring -> quotient of multivariate polynomial ring)

julia> typeof(B)
MPolyQuoRing{MPolyDecRingElem{QQFieldElem, QQMPolyRingElem}}
Expand Down Expand Up @@ -1167,8 +1165,7 @@ Given a homogeneous element `f` of a $\mathbb Z$-graded affine algebra, return t
julia> R, (x, y, z) = graded_polynomial_ring(QQ, ["x", "y", "z"] );

julia> A, p = quo(R, ideal(R, [y-x, z^3-x^3]))
(Quotient of multivariate polynomial ring by ideal(-x + y, -x^3 + z^3), Map from
R to A defined by a julia-function with inverse)
(Quotient of multivariate polynomial ring by ideal(-x + y, -x^3 + z^3), Map: graded multivariate polynomial ring -> quotient of multivariate polynomial ring)

julia> f = p(y^2-x^2+z^4)
-x^2 + y^2 + z^4
Expand Down Expand Up @@ -1367,8 +1364,9 @@ julia> L = homogeneous_component(R, 2);
julia> HC = gens(L[1]);

julia> EMB = L[2]
Map from
R_[2] of dim 10 to R defined by a julia-function with inverse
Map defined by a julia-function with inverse
from r_[2] of dim 10
to graded multivariate polynomial ring in 4 variables over QQ

julia> for i in 1:length(HC) println(EMB(HC[i])) end
z^2
Expand All @@ -1391,9 +1389,10 @@ julia> L = homogeneous_component(A, 2);
julia> HC = gens(L[1]);

julia> EMB = L[2]
Map from
Quotient space over:
Rational field with 7 generators and no relations to A defined by a julia-function with inverse
Map defined by a julia-function with inverse
from quotient space over:
Rational field with 7 generators and no relations
to quotient of multivariate polynomial ring by ideal(-x*z + y^2, -w*z + x*y, -w*y + x^2)

julia> for i in 1:length(HC) println(EMB(HC[i])) end
z^2
Expand Down Expand Up @@ -1425,9 +1424,10 @@ julia> L = homogeneous_component(S, [2,1]);
julia> HC = gens(L[1]);

julia> EMB = L[2]
Map from
homogeneous component of Graded multivariate polynomial ring in 5 variables over QQ of degree Element of G with components [2 1]
to S defined by a julia-function with inverse
Map defined by a julia-function with inverse
from homogeneous component of Graded multivariate polynomial ring in 5 variables over QQ of degree Element of G with components [2 1]

to graded multivariate polynomial ring in 5 variables over QQ

julia> for i in 1:length(HC) println(EMB(HC[i])) end
x[2]^2*y[3]
Expand All @@ -1449,9 +1449,10 @@ julia> L = homogeneous_component(A, [2,1]);
julia> HC = gens(L[1]);

julia> EMB = L[2]
Map from
Quotient space over:
Rational field with 7 generators and no relations to A defined by a julia-function with inverse
Map defined by a julia-function with inverse
from quotient space over:
Rational field with 7 generators and no relations
to quotient of multivariate polynomial ring by ideal(x[1]*y[1] - x[2]*y[2])

julia> for i in 1:length(HC) println(EMB(HC[i])) end
x[2]^2*y[3]
Expand Down
7 changes: 7 additions & 0 deletions src/Rings/NumberField.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@

elem_type(::Type{NfNSGen{T, S}}) where {T, S} = NfNSGenElem{T, S}

is_simple(::NfNSGen) = false

Check warning on line 59 in src/Rings/NumberField.jl

View check run for this annotation

Codecov / codecov/patch

src/Rings/NumberField.jl#L59 

Added line #L59 was not covered by tests

################################################################################
#
# Constructors
Expand Down Expand Up @@ -523,6 +525,11 @@
end
end

function (K::NfNSGen{T, S})(x::NfAbsOrdElem{NfNSGen{T, S}, <:Any}) where {T, S}
@req nf(parent(x)) === K "Parent of element must be an order of the number field"
return elem_in_nf(x)

Check warning on line 530 in src/Rings/NumberField.jl

View check run for this annotation

Codecov / codecov/patch

src/Rings/NumberField.jl#L528-L530 

Added lines #L528 - L530 were not covered by tests
end

################################################################################
#
# Denominator (for absolute fields)
Expand Down
5 changes: 3 additions & 2 deletions src/Rings/PBWAlgebraQuo.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,8 +232,9 @@ julia> Q
(PBW-algebra over Rational field in x, y, z with relations y*x = -x*y, z*x = -x*z, z*y = -y*z)/two_sided_ideal(x^2, y^2, z^2)

julia> q
Map from
PBW-algebra over Rational field in x, y, z with relations y*x = -x*y, z*x = -x*z, z*y = -y*z to (PBW-algebra over Rational field in x, y, z with relations y*x = -x*y, z*x = -x*z, z*y = -y*z)/two_sided_ideal(x^2, y^2, z^2) defined by a julia-function with inverse
Map defined by a julia-function with inverse
from pBW-algebra over Rational field in x, y, z with relations y*x = -x*y, z*x = -x*z, z*y = -y*z
to (PBW-algebra over Rational field in x, y, z with relations y*x = -x*y, z*x = -x*z, z*y = -y*z)/two_sided_ideal(x^2, y^2, z^2)
```

!!! note
Expand Down
6 changes: 2 additions & 4 deletions src/Rings/mpoly-affine-algebras.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,7 @@ julia> I = ideal(R, [x^2, y^3])
ideal(x^2, y^3)

julia> A, _ = quo(R, I)
(Quotient of multivariate polynomial ring by ideal(x^2, y^3), Map from
R to A defined by a julia-function with inverse)
(Quotient of multivariate polynomial ring by ideal(x^2, y^3), Map: graded multivariate polynomial ring -> quotient of multivariate polynomial ring)

julia> L = monomial_basis(A)
6-element Vector{MPolyDecRingElem{QQFieldElem, QQMPolyRingElem}}:
Expand Down Expand Up @@ -133,8 +132,7 @@ julia> I = ideal(R, [x^2])
ideal(x^2)

julia> A, _ = quo(R, I)
(Quotient of multivariate polynomial ring by ideal(x^2), Map from
R to A defined by a julia-function with inverse)
(Quotient of multivariate polynomial ring by ideal(x^2), Map: graded multivariate polynomial ring -> quotient of multivariate polynomial ring)

julia> L = monomial_basis(A, 3)
2-element Vector{MPolyDecRingElem{QQFieldElem, QQMPolyRingElem}}:
Expand Down
5 changes: 3 additions & 2 deletions src/Rings/mpoly-graded.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1288,8 +1288,9 @@ homogeneous component of Graded multivariate polynomial ring in 5 variables over
julia> FG = gens(L[1]);

julia> EMB = L[2]
Map from
S_[1 1] of dim 6 to S defined by a julia-function with inverse
Map defined by a julia-function with inverse
from s_[1 1] of dim 6
to graded multivariate polynomial ring in 5 variables over QQ

julia> for i in 1:length(FG) println(EMB(FG[i])) end
x[2]*y[3]
Expand Down
5 changes: 3 additions & 2 deletions src/Rings/mpolyquo-localizations.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,8 +308,9 @@ Localization
at complement of prime ideal(y - 1, x - a)

julia> iota
Map from
RQ to Localization of quotient of multivariate polynomial ring at complement of prime ideal defined by a julia-function
Map defined by a julia-function
from quotient of multivariate polynomial ring by ideal(2*x^2 - y^3, 2*x^2 - y^5)
to localization of quotient of multivariate polynomial ring at complement of prime ideal
```
""" localization(A::MPolyQuoRing, U::AbsMPolyMultSet)

Expand Down
Loading