Try to make AlgClosureFp tests fail less often #2881
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
force-pushed
the
mh/AlgClosureFp
branch
from
c5f17b4
to
c638e14
Compare
... to make test runs *slightly* easier to reproduce.
Instead of using the global cached versions of the starting fields, use fresh copies to avoid interference by the global effects of previous tests. Of course this does not solve the fundamental issue, but for now it should reduce the number of times CI fails randomly due to this.
fingolfin
force-pushed
the
mh/AlgClosureFp
branch
from
c638e14
to
533045b
Compare
|
@fieker unfortunately this doesn't seem to help |
|
Unfortunately doesn't work, so I made #2888 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the global cached versions of the starting fields,
use fresh copies to avoid interference by the global effects of
previous tests.
Of course this does not solve issue #2691, but for now
it should reduce the number of times CI fails randomly due to this.
This contains PR #2809 because that PR seemed to trigger these failures consistently, so if this PR here now passes, it may actually work...