Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More functionality for Weyl groups #3051

Merged
merged 13 commits into from
Jan 25, 2024
Merged

More functionality for Weyl groups #3051

merged 13 commits into from
Jan 25, 2024

Conversation

felix-roehrich
Copy link
Collaborator

@felix-roehrich felix-roehrich commented Nov 27, 2023 •
edited
Loading

  • make WeylGroups iterable
  • add WeylOrbit functionality
  • add more tests
  • fix bugs in CartanMatrix.jl and RootSystem.jl

@codecov Codecov
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #3051 (6aa1203) into master (de7dcdd) will increase coverage by 0.07%.
Report is 1 commits behind head on master.
The diff coverage is 79.74%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3051      +/-   ##
==========================================
+ Coverage   80.49%   80.57%   +0.07%     
==========================================
  Files         520      522       +2     
  Lines       70069    70422     +353     
==========================================
+ Hits        56403    56743     +340     
- Misses      13666    13679      +13
Files Coverage Δ
experimental/LieAlgebras/src/CoxeterGroup.jl 0.00% <ø> (ø)
experimental/LieAlgebras/src/DynkinDiagram.jl 100.00% <100.00%> (ø)
experimental/LieAlgebras/src/GapWrapper.jl 100.00% <100.00%> (ø)
experimental/LieAlgebras/src/LieAlgebraModule.jl 89.04% <100.00%> (-6.79%) ⬇️
experimental/LieAlgebras/src/LieAlgebras.jl 100.00% <ø> (ø)
...rimental/LieAlgebras/test/LieAlgebraModule-test.jl 96.96% <100.00%> (+6.06%) ⬆️
experimental/LieAlgebras/test/RootSystem-test.jl 90.00% <100.00%> (ø)
experimental/LieAlgebras/test/setup_tests.jl 95.68% <ø> (ø)
src/GAP/wrappers.jl 96.38% <100.00%> (+0.10%) ⬆️
experimental/LieAlgebras/src/AbstractLieAlgebra.jl 70.17% <50.00%> (-0.37%) ⬇️
... and 4 more

... and 4 files with indirect coverage changes

@lgoettgens lgoettgens mentioned this pull request Dec 5, 2023
Closed
@felix-roehrich felix-roehrich changed the title Add docs and tests for WeylGroup.jl More functionality for Weyl groups Jan 24, 2024
@felix-roehrich felix-roehrich marked this pull request as ready for review January 24, 2024 11:10
lgoettgens
lgoettgens approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great overall, thank! just some minor comments

experimental/LieAlgebras/src/CoxeterGroup.jl Show resolved Hide resolved
experimental/LieAlgebras/src/LieAlgebras.jl Outdated Show resolved Hide resolved
experimental/LieAlgebras/src/LieAlgebras.jl Outdated Show resolved Hide resolved
experimental/LieAlgebras/src/WeylGroup.jl Outdated Show resolved Hide resolved
experimental/LieAlgebras/src/WeylGroup.jl Outdated Show resolved Hide resolved
experimental/LieAlgebras/src/WeylGroup.jl Outdated Show resolved Hide resolved
experimental/LieAlgebras/test/WeylGroup-test.jl Show resolved Hide resolved
felix-roehrich and others added 4 commits January 24, 2024 16:07
@felix-roehrich @lgoettgens
Apply suggestions from code review
eedf8f3 
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
@felix-roehrich @lgoettgens
Update experimental/LieAlgebras/src/WeylGroup.jl
656e4af 
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
@felix-roehrich
commit suggestions and format files
968c7b0
@felix-roehrich
sort exports
d5555d3
lgoettgens
lgoettgens approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lgoettgens
Copy link
Member

Can we get a quick merge of this (once CI finishes)? This PR does some GroupsCore shenanigans, which I would like to tackle in #3231.

@lgoettgens
Copy link
Member

Ping @thofma

@thofma thofma merged commit a18cece into oscar-system:master Jan 25, 2024
22 checks passed
@felix-roehrich felix-roehrich deleted the fr/weyl-groups branch January 25, 2024 10:15
HechtiDerLachs pushed a commit to HechtiDerLachs/Oscar.jl that referenced this pull request Jan 26, 2024
@felix-roehrich @HechtiDerLachs
More functionality for Weyl groups (oscar-system#3051)
48d176a
@thofma thofma mentioned this pull request Feb 4, 2024
Merged
ooinaruhugh pushed a commit to ooinaruhugh/Oscar.jl that referenced this pull request Feb 15, 2024
@felix-roehrich @ooinaruhugh
More functionality for Weyl groups (oscar-system#3051)
9d392c6
@thofma thofma mentioned this pull request Feb 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgoettgens lgoettgens lgoettgens approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request topic: LieAlgebras
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felix-roehrich @lgoettgens @thofma