Renaming for localizations

[HechtiDerLachs]

Some work for #3054 .

• un-export a lot of concrete types in the localizations
• rename ambient_ring to simply ring
• un-export some functions

[thofma]

If we have a localized module, how do we get the underlying module back? What is the name of the function?

P.S.: I am just worried about some mismatch, because we have ring, but we cannot have a function named module.

[fingolfin]

Could you say a bit about the motivation for renaming to ambient_ring to ring (I am not opposed, just wondering)

[HechtiDerLachs]

@thofma : There has never been a function to get the underlying module back, really. Do you think we need it? One problem is that the module does not know that it came from a localization in the first place.

@fingolfin : I just recalled various talks with @fieker suggesting to rename base_ring just into ring. The name base_ring might be too established to do this on such short notice. But at least for ambient_ring I thought, I could give it a try.

[thofma]

Sorry, my bad. I was confused.

[codecov]

Codecov Report

Merging #3174 (b223169) into master (76777a9) will increase coverage by 0.00%.
The diff coverage is 76.38%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3174   +/-   ##
=======================================
  Coverage   81.14%   81.14%           
=======================================
  Files         556      556           
  Lines       73894    73894           
=======================================
+ Hits        59962    59963    +1     
+ Misses      13932    13931    -1     

Files	Coverage Δ
...rimental/MatroidRealizationSpaces/test/runtests.jl	100.00% <ø> (ø)
...ometry/Schemes/AffineSchemes/Objects/Attributes.jl	88.34% <ø> (ø)
...ometry/Schemes/AffineSchemes/Objects/Properties.jl	90.32% <ø> (ø)
src/Rings/mpolyquo-localizations.jl	74.69% <100.00%> (ø)
src/deprecations.jl	0.00% <ø> (ø)
src/Modules/Posur.jl	73.77% <50.00%> (ø)
src/Modules/mpoly-localizations.jl	70.64% <75.00%> (ø)
src/Rings/localization_interface.jl	61.49% <50.00%> (ø)
src/Rings/mpoly-localizations.jl	77.42% <78.33%> (ø)

... and 1 file with indirect coverage changes

[lgoettgens]

Could you add deprecations for your renaming?

[HechtiDerLachs]

There is only one command that has only changed its name. For the rest I simply don't want to export it anymore. Is this legitimate? Back in the days when I wrote the code, I simply didn't have a feeling for it.

[lgoettgens]

If there are other dispatches for ambient_ring, you should use @deprecate with a concrete signature instead. It's best if you have a look at deprecations.jl (and maybe put the deprecation there)

[HechtiDerLachs]

@bschroter : It seems that you are using ambient_ring for your realization spaces, too. Could/should this also be changed to ring?

[HechtiDerLachs]

From my side this can be merged. My question to @bschroter was more a heads up and can be resolved elsewhere.

[dcorey2814]

@bschroter : It seems that you are using ambient_ring for your realization spaces, too. Could/should this also be changed to ring?

ambient_ring is referring to the polynomial ring where the defining ideal and multiplicative semigroup live. ring could be ambiguous since one may think this produces the coordinate ring of the matroid realization space.