Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make inj/proj of products groups consistent with other products objects #3201

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Make inj/proj of products groups consistent with other products objects #3201

merged 3 commits into from
Jan 24, 2024

Conversation

lgoettgens
Copy link
Member

Continuation of #2747 as proposed in #2747 (comment).

@fingolfin already approved this in #2747 (comment).

@lgoettgens lgoettgens mentioned this pull request Jan 19, 2024
Open
fingolfin
fingolfin approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me, though perhaps we should wait for the actual resolution of the great direct_product debate of 2024 ?

fingolfin
fingolfin approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it for now so that everything (? at least "more things") use canonical_injection and then if need we can change all of those (or not, or whatever is decided)

@fingolfin fingolfin merged commit ae3351e into oscar-system:master Jan 24, 2024
18 of 22 checks passed
@lgoettgens lgoettgens deleted the lg/canonical_jections branch January 24, 2024 10:52
@thofma thofma mentioned this pull request Feb 4, 2024
Merged
ooinaruhugh pushed a commit to ooinaruhugh/Oscar.jl that referenced this pull request Feb 15, 2024
@lgoettgens @ooinaruhugh
Make inj/proj of products groups consistent with other products objec…
63dc763 
…ts (oscar-system#3201)
@thofma thofma mentioned this pull request Feb 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

Assignees
No one assigned
Labels
topic: groups
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lgoettgens @fingolfin