Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix reference to intersection -> intersect #3214

Merged
merged 1 commit into from
Jan 20, 2024
Merged

docs: fix reference to intersection -> intersect #3214

merged 1 commit into from
Jan 20, 2024

Conversation

benlorenz
Copy link
Member

should fix failing docs deploy on master after latest AbstractAlgebra (due to Nemocas/AbstractAlgebra.jl#1550)

should fix failing docs deploy on master after latest abstractalgebra
@thofma
Copy link
Collaborator

thofma commented Jan 20, 2024

Hm, I think we had this discussion before. Should the downstream tests catch this?

@benlorenz
Copy link
Member Author

benlorenz commented Jan 20, 2024

We are running doctests in the downstream tests (via doctest(...)), but this doesn't check references in the docstrings. I think this needs makedocs(...) which might need the docs-sources of the extra packages?

@thofma thofma merged commit 8f08dd8 into master Jan 20, 2024
21 of 23 checks passed
@thofma thofma deleted the bl/docfix branch January 20, 2024 11:28
@thofma
Copy link
Collaborator

thofma commented Jan 20, 2024

Ah, this is something different. Hm, that sounds more complicated. Let's hope we slow down on breaking releases after 1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants