let right_cosets return a G-set
#3223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3223 +/- ##
=======================================
Coverage 81.63% 81.63%
=======================================
Files 546 546
Lines 72887 72960 +73
=======================================
+ Hits 59499 59559 +60
- Misses 13388 13401 +13
|
fingolfin
approved these changes
Jan 24, 2024
ThomasBreuer
force-pushed
the
TB_right_cosets
branch
from
1ee4e6e
to
40158e7
Compare
fingolfin
reviewed
Jan 25, 2024
fingolfin
reviewed
Jan 25, 2024
| @@ -258,12 +288,12 @@ Permutation group of degree 4 and order 24 | |||
| julia> H = symmetric_group(3) | |||
| Permutation group of degree 3 and order 6 | |||
|
|
|||
| julia> left_cosets(G,H) | |||
| julia> left_cosets(G, H) | |||
There was a problem hiding this comment.
Now left_cosets behaves quite different from right_cosets... We should either warn about this; or else turn that into a G-set, too (I guess by letting
There was a problem hiding this comment.
Do we want to support left cosets at all?
In GAP, there is no function LeftTransversal. The GAP function LeftCosets belongs to the utils package (without documentation, the documentation belongs to the groupoids package). I would recommend not to use left cosets.
fingolfin
approved these changes
Jan 25, 2024
- add `GSetByRightTransversal` - change `right_cosets` to return a `GSetByRightTransversal` object - change `show` methods for `GSetByElements` and `GroupCoset`
ThomasBreuer
force-pushed
the
TB_right_cosets
branch
from
bb4f886
to
3f21de1
Compare
HechtiDerLachs
pushed a commit
to HechtiDerLachs/Oscar.jl
that referenced
this pull request
Jan 26, 2024
* let `right_cosets` return a G-set - add `GSetByRightTransversal` - change `right_cosets` to return a `GSetByRightTransversal` object - change `show` methods for `GSetByElements` and `GroupCoset` * address comments * adjust `show` values
ooinaruhugh
pushed a commit
to ooinaruhugh/Oscar.jl
that referenced
this pull request
Feb 15, 2024
* let `right_cosets` return a G-set - add `GSetByRightTransversal` - change `right_cosets` to return a `GSetByRightTransversal` object - change `show` methods for `GSetByElements` and `GroupCoset` * address comments * adjust `show` values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GSetByRightTransversalright_cosetsto return aGSetByRightTransversalobjectshowmethods forGSetByElementsandGroupCosetresolves #3221,
addresses the comment about
right_cosetsin the discussion of #3216