use stored OD values for factor groups #3248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and set obvious `orthogonal_discriminants` values for perfect central extensions
fingolfin
approved these changes
Jan 26, 2024
| res[mp[l[2]]] = l[4] | ||
| end | ||
| # Set values for faithful characters if applicable. | ||
| perf = (length(filter(i -> degree(tbl[i]) == 1, 1:length(tbl))) == 1) |
There was a problem hiding this comment.
Suggested change
| perf = (length(filter(i -> degree(tbl[i]) == 1, 1:length(tbl))) == 1) | |
| perf = (count(i -> degree(tbl[i]) == 1, 1:length(tbl)) == 1) |
or even nicer:
Suggested change
| perf = (length(filter(i -> degree(tbl[i]) == 1, 1:length(tbl))) == 1) | |
| perf = (count(x -> degree(x) == 1, tbl) == 1) |
Comment on lines
+155
to
+156
| for i in 1:length(tbl) | ||
| chi = tbl[i] |
There was a problem hiding this comment.
Suggested change
| for i in 1:length(tbl) | |
| chi = tbl[i] | |
| for chi in tbl |
There was a problem hiding this comment.
I need i in the assignments.
Comment on lines
160
to
162
| if mod(deg, 4 ) == 0 | ||
| res[i] = "1" | ||
| elseif mod(deg, 2 ) == 0 |
There was a problem hiding this comment.
Suggested change
| if mod(deg, 4 ) == 0 | |
| res[i] = "1" | |
| elseif mod(deg, 2 ) == 0 | |
| if mod(deg, 4) == 0 | |
| res[i] = "1" | |
| elseif mod(deg, 2) == 0 |
or
Suggested change
| if mod(deg, 4 ) == 0 | |
| res[i] = "1" | |
| elseif mod(deg, 2 ) == 0 | |
| if mod(deg, 4) == 0 | |
| res[i] = "1" | |
| elseif mod(deg, 2) == 0 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3248 +/- ##
==========================================
+ Coverage 81.63% 81.66% +0.02%
==========================================
Files 546 546
Lines 73159 73146 -13
==========================================
+ Hits 59726 59732 +6
+ Misses 13433 13414 -19
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and set obvious
orthogonal_discriminantsvalues automatically for perfect central extensionsThis way, the character table display with ODs works automatically for "2.A8", "2.HS", etc.