Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add G-set functionality for conjugacy classes #3268

Merged
merged 3 commits into from
Jan 31, 2024
Merged

add G-set functionality for conjugacy classes #3268

merged 3 commits into from
Jan 31, 2024

Conversation

ThomasBreuer
Copy link
Member

and changed the show methods for conjugacy classes

@ThomasBreuer
add G-set functionality for conjugacy classes
d3eafa9 
and changed the `show` methods for conjugacy classes
@ThomasBreuer
Copy link
Member Author

addresses issue #3261

@codecov Codecov
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Merging #3268 (d3eafa9) into master (5857e99) will increase coverage by 4.59%.
Report is 1 commits behind head on master.
The diff coverage is 82.97%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3268      +/-   ##
==========================================
+ Coverage   77.03%   81.62%   +4.59%     
==========================================
  Files         546      546              
  Lines       73151    73349     +198     
==========================================
+ Hits        56352    59874    +3522     
+ Misses      16799    13475    -3324
Files Coverage Δ
src/Groups/gsets.jl 88.23% <100.00%> (+4.70%) ⬆️
src/Groups/GAPGroups.jl 91.64% <82.60%> (+12.43%) ⬆️

... and 175 files with indirect coverage changes

@ThomasBreuer ThomasBreuer marked this pull request as draft January 30, 2024 10:58
fingolfin
fingolfin approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is marked as draft, but what is missing? Additional work can always be done in a follow-up PR, after all?

src/Groups/GAPGroups.jl Outdated Show resolved Hide resolved
src/Groups/GAPGroups.jl Outdated Show resolved Hide resolved
@ThomasBreuer ThomasBreuer marked this pull request as ready for review January 31, 2024 08:47
@fingolfin fingolfin enabled auto-merge (squash) January 31, 2024 10:56
@fingolfin fingolfin merged commit 34c5a22 into oscar-system:master Jan 31, 2024
20 checks passed
@ThomasBreuer ThomasBreuer deleted the TB_ccl_gset branch January 31, 2024 11:45
@thofma thofma mentioned this pull request Feb 4, 2024
Merged
ooinaruhugh pushed a commit to ooinaruhugh/Oscar.jl that referenced this pull request Feb 15, 2024
@ThomasBreuer @ooinaruhugh
add G-set functionality for conjugacy classes (oscar-system#3268)
2ba6329 
* add G-set functionality for conjugacy classes

and changed the `show` methods for conjugacy classes

* address comments (introduce `action_range`)

* `GroupConjClass` is a subtype of `GSet`
@thofma thofma mentioned this pull request Feb 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThomasBreuer @fingolfin