Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add is_conjugate_subgroup_with_data #3281

Merged

Conversation

ThomasBreuer
Copy link
Member

and changed is_conjugate_subgroup to return only true or false

(The function is_conjugate_subgroup seems to be unused throughout the code,
thus no calls of it had to be adjusted.
And its docstring is currently not part of the manual.)

resolves #3262

and changed `is_conjugate_subgroup` to return only `true` or `false`
@fingolfin
Copy link
Member

I think is_conjugate_subgroup may have been intended for the Galois groups code, perhaps @fieker recalls

@fingolfin fingolfin enabled auto-merge (squash) January 31, 2024 10:57
@fingolfin fingolfin merged commit a8a2056 into oscar-system:master Jan 31, 2024
20 checks passed
@ThomasBreuer ThomasBreuer deleted the TB_is_conjugate_subgroup branch January 31, 2024 11:23
ooinaruhugh pushed a commit to ooinaruhugh/Oscar.jl that referenced this pull request Feb 15, 2024
and changed `is_conjugate_subgroup` to return only `true` or `false`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve is_conjugate_subgroup
2 participants