Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for algebraic_closure(::QQField) #3283

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Prepare for algebraic_closure(::QQField) #3283

merged 1 commit into from
Jan 31, 2024

Conversation

lgoettgens
Copy link
Member

Once this is merged, adding the above method to Nemo won't break Oscar anymore

fingolfin
fingolfin approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Of course we can remove the if isdefined bit once a Nemo with this out and we adjusted the compat bound in Project.toml to require at least that new version.

@lgoettgens
Copy link
Member Author

Looks good to me. Of course we can remove the if isdefined bit once a Nemo with this out and we adjusted the compat bound in Project.toml to require at least that new version.

That was my intention

@lgoettgens lgoettgens mentioned this pull request Jan 31, 2024
Merged
@fingolfin fingolfin enabled auto-merge (squash) January 31, 2024 11:30
@fingolfin fingolfin merged commit 298e142 into oscar-system:master Jan 31, 2024
20 checks passed
@thofma thofma mentioned this pull request Feb 4, 2024
Merged
@lgoettgens lgoettgens mentioned this pull request Feb 7, 2024
Merged
ooinaruhugh pushed a commit to ooinaruhugh/Oscar.jl that referenced this pull request Feb 15, 2024
@lgoettgens @ooinaruhugh
Prepare for algebraic_closure(::QQField) (oscar-system#3283)
c4821a6
@thofma thofma mentioned this pull request Feb 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lgoettgens @fingolfin