Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename and change some *_reps functions #3291

Merged
merged 16 commits into from
Feb 16, 2024
Merged

rename and change some *_reps functions #3291

merged 16 commits into from
Feb 16, 2024
+266 −253

Commits on Feb 15, 2024

  1. replace hall_subgroup_reps by hall_subgroups

    @ThomasBreuer
    ThomasBreuer committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    03d9a59 View commit details
    Browse the repository at this point in the history

  2. replace lowindex_subgroups_reps by low_index_subgroups

    @ThomasBreuer
    ThomasBreuer committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    165b874 View commit details
    Browse the repository at this point in the history

  3. replace complement_class_reps by complement_classes

    @ThomasBreuer
    ThomasBreuer committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    0959035 View commit details
    Browse the repository at this point in the history

  4. replace maximal_subgroup_reps by maximal_subgroups 

    - deprecate `conjugacy_classes_maximal_subgroups`, `maximal_subgroup_reps`
- let `maximal_subgroups` return subgroup classes
- adjust calls of these functions
    @ThomasBreuer
    ThomasBreuer committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    ab1905b View commit details
    Browse the repository at this point in the history

  5. adjust tests involving maximal_subgroups

    @ThomasBreuer
    ThomasBreuer committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    23409fc View commit details
    Browse the repository at this point in the history

  6. rename conjugacy_classes_subgroups to subgroup_classes 

    and deprecate `subgroup_reps` and `subgroups` (the latter only for `GAPGroup`s)
    @ThomasBreuer
    ThomasBreuer committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    ab524ed View commit details
    Browse the repository at this point in the history

  7. rename *_subgroups to *_subgroup_classes 

    for `*` one of `hall`, `maximal`, `low_index`
    @ThomasBreuer
    ThomasBreuer committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    840f656 View commit details
    Browse the repository at this point in the history

  8. do not use deprecated functions in tests

    @ThomasBreuer
    ThomasBreuer committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    9ad6636 View commit details
    Browse the repository at this point in the history

  9. adjust one more test using a deprecated function

    @ThomasBreuer
    ThomasBreuer committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    48beaf9 View commit details
    Browse the repository at this point in the history

  10. adjust some doctest outputs again

    @ThomasBreuer
    ThomasBreuer committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    0e46a7f View commit details
    Browse the repository at this point in the history

  11. address comments

    @ThomasBreuer
    ThomasBreuer committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    a48e8e5 View commit details
    Browse the repository at this point in the history

  12. add missing doc. for low_index_subgroup_classes 

    Why did I not get an error in the local build?
    @ThomasBreuer
    ThomasBreuer committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    3b76df2 View commit details
    Browse the repository at this point in the history

  13. fixes

    @ThomasBreuer
    ThomasBreuer committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    ed9d640 View commit details
    Browse the repository at this point in the history

  14. address comments

    @ThomasBreuer
    ThomasBreuer committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    4a02d18 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Merge branch 'master' into TB_no_subgroup_reps

    @fingolfin
    fingolfin committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    498746a View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review

    @fingolfin
    fingolfin committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    c141e0f View commit details
    Browse the repository at this point in the history