sphere recognition heuristics and friends #3362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micjoswig
added
the
backport 1.0.x
lgoettgens
reviewed
Feb 13, 2024
benlorenz
reviewed
Feb 13, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3362 +/- ##
=======================================
Coverage 81.84% 81.84%
=======================================
Files 557 557
Lines 74459 74462 +3
=======================================
+ Hits 60942 60945 +3
Misses 13517 13517
|
benlorenz
approved these changes
Feb 14, 2024
ooinaruhugh
pushed a commit
to ooinaruhugh/Oscar.jl
that referenced
this pull request
Feb 15, 2024
* SimplicialConmplex: is_manifold * SimplicialComplex: is_sphere, is_ball * SimplicialComplex: docs added * SimplicialComplex: is_sphere, is_ball, is_manifold heuristics: tests and docs * Fix doctest typos * return type annotation -> type assertion --------- Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de> Co-authored-by: Benjamin Lorenz <benlorenz@users.noreply.github.com>
benlorenz
removed
the
backport 1.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carrying over sphere recognition and friends from polymake. Three-valued logics works now, with recent addition to Polymake.jl.