Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix doctest following algebraicsolving 0.4.10 #3377

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

benlorenz
Copy link
Member

@benlorenz benlorenz commented Feb 16, 2024

algebraic-solving/AlgebraicSolving.jl#42 seems to have changed some output ordering in the doctest. I assume that this is still correct and we just need to adjust the printing.

cc: @joschmitt

Details
│ Subexpression:
│ 
│ Oscar._normal_form_f4(A, J)
│ 
│ Evaluated output:
│ 
│ 3-element Vector{FqMPolyRingElem}:
│  a^3
│  2*a^3 + 2*a + 65519*c
│  4*a + 65519*c^2 + 65520*c + 5
│ 
│ Expected output:
│ 
│ 3-element Vector{FqMPolyRingElem}:
│  a^3
│  2*a^3 + 2*a + 65519*c
│  65519*c^2 + 4*a + 65520*c + 5
│ 
│   diff =
│    3-element Vector{FqMPolyRingElem}:
│     a^3
│     2*a^3 + 2*a + 65519*c
│     65519*c^2 + 4*a + 65519*c^2 + 65520*c + 5
└ @ Documenter ~/work/Oscar.jl/Oscar.jl/src/Rings/groebner.jl:1022

e.g. https://github.com/oscar-system/Oscar.jl/actions/runs/7927819812/job/21644888121#step:8:3229

Copy link
Member

@joschmitt joschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is correct. Thank you!

@benlorenz
Copy link
Member Author

First doctests are already passing, once all doctests are done I will merge this early to unbreak CI on master and PRs.

@benlorenz benlorenz merged commit 82f6440 into master Feb 16, 2024
21 checks passed
@benlorenz benlorenz deleted the bl/fixdoctest branch February 16, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants