Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TropicalGeometry: add and improve polymake conversions #3426

Merged
merged 3 commits into from
Feb 27, 2024
Merged

TropicalGeometry: add and improve polymake conversions #3426

merged 3 commits into from
Feb 27, 2024

Conversation

benlorenz
Copy link
Member

@codecov Codecov
Copy link

codecov bot commented Feb 26, 2024 •
edited
Loading

Codecov Report

Merging #3426 (54f581a) into master (db3dc1f) will not change coverage.
Report is 5 commits behind head on master.
The diff coverage is 63.63%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3426   +/-   ##
=======================================
  Coverage   81.89%   81.89%           
=======================================
  Files         561      561           
  Lines       75125    75125           
=======================================
  Hits        61520    61520           
  Misses      13605    13605
Files Coverage Δ
src/PolyhedralGeometry/helpers.jl 80.85% <100.00%> (+0.42%) ⬆️
src/TropicalGeometry/hypersurface.jl 56.25% <50.00%> (-5.29%) ⬇️
src/Serialization/polymake.jl 69.13% <0.00%> (-2.66%) ⬇️
src/TropicalGeometry/semiring.jl 62.40% <57.14%> (-0.30%) ⬇️

... and 2 files with indirect coverage changes

YueRen
YueRen approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@YueRen YueRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this will make my life much easier! Oh, I didn't know [td-sum(alpha); alpha] for alpha in exponents(f)) works as it does.

@benlorenz benlorenz marked this pull request as ready for review February 26, 2024 14:53
@benlorenz benlorenz merged commit 222c200 into master Feb 27, 2024
24 checks passed
@benlorenz benlorenz deleted the bl/pmtropnum branch February 27, 2024 14:25
mjrodgers pushed a commit to mjrodgers/Oscar.jl that referenced this pull request Feb 28, 2024
@benlorenz @mjrodgers
TropicalGeometry: add and improve polymake conversions (oscar-system#…
c9a3f14 
…3426)

* tropical: add conversion helpers for polymake tropicalnumber

* tropicalgeometry: simplify several polymake conversions

* use accessor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YueRen YueRen YueRen approved these changes

Assignees
No one assigned
Labels
package: Polymake topic: tropical geometry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benlorenz @YueRen @lgoettgens