Backport for 1.0: G-Modules missing methods (part 1) (#3441) #3477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* formatter * Write `extension_of_scalars`, add `absolute_frobenius` * Fix `gmodule_over` for finite fields * add test for `extension_of_scalars` * Update experimental/GModule/test/runtests.jl Co-authored-by: Max Horn <max@quendi.de> * export `extension_of_scalars` * export again * experimental subfields now working (better) * refine the is_disjoint * export the lattice in some way * improve linear disjoint and strategy if many factors * fixes for "THE" book * minor * invar._classes * fix formatting * remove methods that are already merged to `AbstractAlgebra.jl` * Update deprecated types * Update AA Dependency * Update experimental/GaloisGrp/src/Subfields.jl * Partial fix for failing supfield test * More partial fix for failing subfield test section * Update experimental/GModule/Brueckner.jl Co-authored-by: Max Horn <max@quendi.de> * Update experimental/GModule/Brueckner.jl Co-authored-by: Max Horn <max@quendi.de> * Update experimental/GModule/GModule.jl Co-authored-by: Max Horn <max@quendi.de> * update `fp_group_with_isomorphism` * Update experimental/GModule/Brueckner.jl Co-authored-by: Max Horn <max@quendi.de> * Update experimental/GModule/Brueckner.jl Co-authored-by: Max Horn <max@quendi.de> * fix error in subfield lattice `intersect` * Apply suggestions from code review --------- Co-authored-by: Max Horn <max@quendi.de> Co-authored-by: Claus Fieker <fieker@mathematik.uni-kl.de> Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com> (cherry picked from commit 7925f18)
benlorenz
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-1.0 #3477 +/- ##
===============================================
+ Coverage 81.85% 82.10% +0.24%
===============================================
Files 563 563
Lines 75517 75663 +146
===============================================
+ Hits 61813 62120 +307
+ Misses 13704 13543 -161
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @fingolfin