Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization: fix save/load of Int matrices/vectors in polymake numberfield objects #3508

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

benlorenz
Copy link
Member

No description provided.

@benlorenz benlorenz marked this pull request as draft March 12, 2024 11:44
@benlorenz benlorenz marked this pull request as ready for review March 12, 2024 13:36
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Merging #3508 (a25a8ea) into master (653fded) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3508      +/-   ##
==========================================
- Coverage   82.18%   82.18%   -0.01%     
==========================================
  Files         563      563              
  Lines       75860    75862       +2     
==========================================
+ Hits        62344    62345       +1     
- Misses      13516    13517       +1     
Files Coverage Δ
src/Serialization/polymake.jl 69.66% <50.00%> (-0.46%) ⬇️

@benlorenz benlorenz enabled auto-merge (squash) March 12, 2024 14:42
@benlorenz benlorenz added the backport 1.0.x Should be backported to the release 1.0 branch label Mar 12, 2024
@benlorenz benlorenz merged commit 5acd5c5 into master Mar 12, 2024
27 checks passed
@benlorenz benlorenz deleted the bl/savepmint branch March 12, 2024 14:51
benlorenz added a commit that referenced this pull request Apr 9, 2024
…erfield objects (#3508)

* Serialization: fix save/load of Int matrices/vectors in polymake numberfield objects

* Update test/Serialization/PolyhedralGeometry.jl

* fix for macos

(cherry picked from commit 5acd5c5)
@benlorenz benlorenz mentioned this pull request Apr 9, 2024
@benlorenz benlorenz removed the backport 1.0.x Should be backported to the release 1.0 branch label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants