Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TropicalGeometry: fixed typo in documentation #3552

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Conversation

YueRen
Copy link
Member

@YueRen YueRen commented Apr 2, 2024

Fixed a typo in documentation where primary ideals should be principal ideals.

Found by @VictoriaSchleis.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Merging #3552 (2600073) into master (92849f8) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3552   +/-   ##
=======================================
  Coverage   82.16%   82.17%           
=======================================
  Files         568      568           
  Lines       77168    77169    +1     
=======================================
+ Hits        63406    63410    +4     
+ Misses      13762    13759    -3     
Files Coverage Δ
src/TropicalGeometry/variety.jl 29.62% <ø> (ø)

... and 2 files with indirect coverage changes

Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
@YueRen
Copy link
Member Author

YueRen commented Apr 2, 2024

Ah, there is always one more typo. Thanks @lgoettgens!

@joschmitt joschmitt added documentation Improvements or additions to documentation backport 1.0.x Should be backported to the release 1.0 branch labels Apr 3, 2024
@fingolfin fingolfin merged commit 1ed5322 into master Apr 3, 2024
31 checks passed
@fingolfin fingolfin deleted the yr/tropicalBugs branch April 3, 2024 07:28
benlorenz pushed a commit that referenced this pull request Apr 9, 2024
@benlorenz benlorenz mentioned this pull request Apr 9, 2024
@benlorenz benlorenz removed the backport 1.0.x Should be backported to the release 1.0 branch label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants