Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests of book chapter to CI. #3588

Merged
merged 51 commits into from
Apr 12, 2024
Merged

Add tests of book chapter to CI. #3588

merged 51 commits into from
Apr 12, 2024

Conversation

lkastner
Copy link
Member

Adds most of the book chapters to the CI as test cases. Some mechanics are introduced to really test with the (almost) original jlcons.

@lgoettgens lgoettgens added the testsuite Everything concerning testsuite label Apr 11, 2024
test/runtests.jl Outdated Show resolved Hide resolved
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Merging #3588 (5e0e3a5) into master (3b3a806) will increase coverage by 0.44%.
Report is 10 commits behind head on master.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3588      +/-   ##
==========================================
+ Coverage   81.72%   82.17%   +0.44%     
==========================================
  Files         573      573              
  Lines       77503    77618     +115     
==========================================
+ Hits        63343    63780     +437     
+ Misses      14160    13838     -322     
Files Coverage Δ
src/utils/tests.jl 60.95% <0.00%> (-0.59%) ⬇️

... and 68 files with indirect coverage changes

@thofma
Copy link
Collaborator

thofma commented Apr 11, 2024

Pretty cool!

@benlorenz benlorenz added the backport 1.0.x Should be backported to the release 1.0 branch label Apr 12, 2024
@benlorenz
Copy link
Member

I added a backport label, but this needs some manual work to undo some changes in the output for master / reimport of the original jlcon files.

@lkastner lkastner merged commit 1870bfd into master Apr 12, 2024
30 checks passed
@lkastner lkastner deleted the lk/booktests branch April 12, 2024 11:57
@benlorenz benlorenz mentioned this pull request Apr 12, 2024
@benlorenz benlorenz removed the backport 1.0.x Should be backported to the release 1.0 branch label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testsuite Everything concerning testsuite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants