Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indentation of doc strings #3744

Merged
merged 1 commit into from
May 16, 2024

Conversation

joschmitt
Copy link
Member

@joschmitt joschmitt commented May 16, 2024

The function name in a doc strings must be indented by 4 spaces to be printed correctly in the REPL.

@joschmitt joschmitt added documentation Improvements or additions to documentation backport 1.0.x Should be backported to the release 1.0 branch labels May 16, 2024
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.31%. Comparing base (f9e5c0f) to head (3402dd9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3744      +/-   ##
==========================================
- Coverage   81.32%   81.31%   -0.01%     
==========================================
  Files         579      579              
  Lines       78982    78982              
==========================================
- Hits        64229    64228       -1     
- Misses      14753    14754       +1     
Files Coverage Δ
experimental/LieAlgebras/src/LieSubalgebra.jl 66.97% <ø> (ø)
experimental/LieAlgebras/src/RootSystem.jl 62.42% <ø> (ø)
...ntal/QuadFormAndIsom/src/lattices_with_isometry.jl 99.44% <ø> (ø)
experimental/Schemes/src/Sheaves.jl 64.70% <ø> (ø)
experimental/Schemes/src/SpaceGerms.jl 69.91% <ø> (ø)
experimental/Schemes/src/elliptic_surface.jl 4.47% <ø> (ø)
...c/AlgebraicGeometry/Curves/ProjectivePlaneCurve.jl 91.35% <ø> (ø)
...ometry/Schemes/AffineSchemes/Objects/Attributes.jl 89.88% <ø> (ø)
...ometry/Schemes/AffineSchemes/Objects/Properties.jl 90.45% <ø> (ø)
...metry/Schemes/CoveredSchemes/Objects/Properties.jl 78.04% <ø> (ø)
... and 12 more

... and 1 file with indirect coverage changes

Copy link
Member

@lkastner lkastner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@joschmitt
Copy link
Member Author

Two approvals, so merge please. I am not allowed to.

@lgoettgens lgoettgens merged commit 5bad134 into oscar-system:master May 16, 2024
28 of 29 checks passed
@joschmitt joschmitt deleted the js/whitespace branch May 16, 2024 13:56
@benlorenz benlorenz mentioned this pull request May 23, 2024
19 tasks
benlorenz pushed a commit that referenced this pull request May 23, 2024
@benlorenz benlorenz removed the backport 1.0.x Should be backported to the release 1.0 branch label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants