Adv/update serialization docs #3793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonydellavecchia
added
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3793 +/- ##
=======================================
Coverage 81.27% 81.27%
=======================================
Files 580 580
Lines 79358 79358
=======================================
Hits 64502 64502
Misses 14856 14856
|
micjoswig
added
the
backport 1.0.x
|
I made several small changes. Fine with me for now. |
micjoswig
approved these changes
May 26, 2024
There was a problem hiding this comment.
@benlorenz : I did not merge the current master into this branch, to avoid possible issues with backporting. That's also why I do not merge this branch into the master. Please take care of this.
joschmitt
reviewed
May 27, 2024
Co-authored-by: Johannes Schmitt <schmitt@mathematik.uni-kl.de>
benlorenz
pushed a commit
that referenced
this pull request
May 30, 2024
* better linking to dev documentation * answering johns questions * started on intro to serialization docs * added a couple paragraphs for external software implementations * more paragraphs on external implementations * remove notes that were never meant to be in final version * fix some typos * some rearrangements * updating serialization docs * fix linking error in test * Apply suggestions from code review Co-authored-by: Johannes Schmitt <schmitt@mathematik.uni-kl.de> --------- Co-authored-by: Michael Joswig <joswig@math.tu-berlin.de> Co-authored-by: Johannes Schmitt <schmitt@mathematik.uni-kl.de> Co-authored-by: Benjamin Lorenz <benlorenz@users.noreply.github.com> (cherry picked from commit d2ea9d7)
benlorenz
removed
the
backport 1.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some updates to serialization documentation.
Some links from the general documentation have been added, including a link to the developer document.
Details about external implementation has been added, and an example on how polynomials are encoded.
Related to #3761