add a paragraph about CTRL-C in Julia and GAP #3814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasBreuer
added
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3814 +/- ##
==========================================
- Coverage 81.28% 81.25% -0.03%
==========================================
Files 580 580
Lines 79352 79353 +1
==========================================
- Hits 64498 64481 -17
- Misses 14854 14872 +18 |
fingolfin
reviewed
May 29, 2024
|
|
||
| In a Julia session, one gets automatically back to the Julia prompt | ||
| when an error occurs or when the user hits ctrl-C, | ||
| and again some objects may be corrupted afterwards. |
There was a problem hiding this comment.
As I stated on Monday: this corruption issue in principle affects everything, including (AFAIK) code provided by the other cornerstones, and even native Julia code. So it feels odd to me to single out that it can happen when calling into GAP.
There was a problem hiding this comment.
The section is about differences between Julia and GAP, here the fact that GAP sessions have a break loop and Julia has not.
joschmitt
added
the
backport 1.0.x
fingolfin
approved these changes
May 31, 2024
benlorenz
pushed a commit
that referenced
this pull request
May 31, 2024
(cherry picked from commit a5df540)
benlorenz
removed
the
backport 1.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.