Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Regression in K3Auto #3847

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Fix Regression in K3Auto #3847

merged 1 commit into from
Jun 12, 2024

Conversation

simonbrandhorst
Copy link
Collaborator

No description provided.

@simonbrandhorst simonbrandhorst added the backport 1.0.x Should be backported to the release 1.0 branch label Jun 12, 2024
@simonbrandhorst
Copy link
Collaborator Author

Fix needed for software presentation. Please merge & packport asap. @benlorenz @aaruni96

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.79%. Comparing base (6134bb9) to head (265e223).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3847      +/-   ##
==========================================
+ Coverage   81.39%   81.79%   +0.40%     
==========================================
  Files         580      580              
  Lines       79797    79833      +36     
==========================================
+ Hits        64952    65302     +350     
+ Misses      14845    14531     -314     
Files Coverage Δ
src/AlgebraicGeometry/Surfaces/K3Auto.jl 83.99% <100.00%> (+8.42%) ⬆️

... and 34 files with indirect coverage changes

@thofma thofma merged commit 7e5d14d into master Jun 12, 2024
30 checks passed
@thofma thofma deleted the sb/fixes branch June 12, 2024 12:45
benlorenz pushed a commit that referenced this pull request Jun 17, 2024
(cherry picked from commit 7e5d14d)
@benlorenz benlorenz mentioned this pull request Jun 17, 2024
@benlorenz benlorenz removed the backport 1.0.x Should be backported to the release 1.0 branch label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants