-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matroid serialisation and matroid encodings #3886
Conversation
…ing the revlex encoding
deleted some wrong changes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3886 +/- ##
==========================================
+ Coverage 83.99% 84.01% +0.02%
==========================================
Files 591 592 +1
Lines 81386 81750 +364
==========================================
+ Hits 68359 68683 +324
- Misses 13027 13067 +40
|
thx Benjamin Co-authored-by: Benjamin Lorenz <benlorenz@users.noreply.github.com>
Co-authored-by: antonydellavecchia <antonydellavecchia@gmail.com>
Co-authored-by: antonydellavecchia <antonydellavecchia@gmail.com>
Co-authored-by: antonydellavecchia <antonydellavecchia@gmail.com>
I am not sure if the "draft" status means that more comments are welcome, but here is a minor comment. The function signatures are sometimes annotated with an explicit
We usually don't do this and I think in none of the cases here it is necessary. |
This adds the ability to save matroids using the
mrdi
file format. Currently this only allows you to save matroids whose groundset is of typeVector{Int}
, arbitrary groundsets are not possible with this implementation. Maybe something for @antonydellavecchia to look into.This also adds a functions,
matroid_hex
, which is a way of encoding a matroid into a string using revlex_bases_encoding.matroid_hex
is an encoding used in the paper Quantum automorphisms of matroids.The encoding style also gets a function to retrieve the matroid from the encoded string
matroid_from_matroid_hex
. Suggestions for the names of the functions are welcome :)This is part of the step-by-step merge of the QuantumAutomorphismGroups.jl package.
@danteluber Please Look at this!