For Modules over PBWAlgRing and PBWAlgQuo #3900
Conversation
| @@ -0,0 +1,61 @@ | |||
| @testset "modules over PBWAlgQuo" begin | |||
| #Free Module tests | |||
| E,x = exterior_algebra(QQ, 3) | |||
There was a problem hiding this comment.
This function is part of experimental and should thus not be used in the tests for src/ code
There was a problem hiding this comment.
True. Though maybe we need to look into promoting exterior_algebra one of these days?
In any case, note that this PR is still a very early draft, I mainly asked @Lax202 to open it so we can better see what she's doing and what the state is, and then discuss it. The code still needs to be consolidated into a new source file, and that may very well ultimately end up in the experimental tree. We'll see.
There was a problem hiding this comment.
In the meantime this was merged as part of PR #3988 which copied the tests from here. If we still don't want the exterior_algebra call here, then someone else should remove it from there.
|
This needs a decision how to proceed regarding the orderings. Perhaps @wdecker will be in this week, so we can have a chat about it? Or Zoom/Phone/whatever? |
|
@fingolfin Zooom, gathertown is o.k. when? |
|
|
||
| function length(x::PBWAlgQuoElem) | ||
| return length(x.data.sdata) | ||
| end |
There was a problem hiding this comment.
These two functions don't belong in this file, but should instead be with the other PBWAlgQuo machinery
| return FreeMod{elem_type(R)}(n, R, [Symbol("$name[$i]") for i=1:n]) | ||
| end | ||
|
|
||
| function FreeMod(R::PBWAlgQuo, names::Vector{String}; cached::Bool=false) |
There was a problem hiding this comment.
| function FreeMod(R::PBWAlgQuo, names::Vector{String}; cached::Bool=false) | |
| function FreeMod(R::PBWAlgQuo, names::Vector{<:VarName}; cached::Bool=false) |
To allow more types of inputs
| return FreeMod{elem_type(R)}(length(names), R, Symbol.(names)) | ||
| end | ||
|
|
||
| function FreeMod(R::PBWAlgRing, names::Vector{String}; cached::Bool=false) |
There was a problem hiding this comment.
| function FreeMod(R::PBWAlgRing, names::Vector{String}; cached::Bool=false) | |
| function FreeMod(R::PBWAlgRing, names::Vector{<:VarName}; cached::Bool=false) |
| # singelem = x.data.sdata | ||
| # ptr = singelem.ptr | ||
|
|
||
| #end |
There was a problem hiding this comment.
| #end | |
| #end | |
Empty line at end of file missing
This is a draft pull request for the work to extend FreeMod, SubModuleofFreeModule, SubquoModule to PBWAlgRing and PBWAlgQuo. The aim is to extend the Groaner machinery as well.