Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports for 1.1.1 #3910

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Backports for 1.1.1 #3910

merged 4 commits into from
Jul 3, 2024

Conversation

benlorenz
Copy link
Member

simonbrandhorst and others added 4 commits July 3, 2024 16:45
* speedup elliptic surfaces

(cherry picked from commit 09c52c1)
* catch a corner case for elliptic surfaces

* allow to turn minimization off

* remove forgotten show

(cherry picked from commit 5dcfffb)
@HechtiDerLachs
Copy link
Collaborator

Notebook on elliptic fibrations is up and running on this branch. Thanks for compiling this!

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 88.31169% with 9 lines in your changes missing coverage. Please review.

Project coverage is 83.78%. Comparing base (d0b75de) to head (f0b6eb7).

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.1    #3910      +/-   ##
===============================================
+ Coverage        81.95%   83.78%   +1.82%     
===============================================
  Files              581      581              
  Lines            80160    80220      +60     
===============================================
+ Hits             65697    67211    +1514     
+ Misses           14463    13009    -1454     
Files Coverage Δ
experimental/Schemes/src/IdealSheaves.jl 78.55% <100.00%> (+6.22%) ⬆️
experimental/Schemes/src/elliptic_surface.jl 87.30% <83.92%> (+82.83%) ⬆️

... and 18 files with indirect coverage changes

@joschmitt
Copy link
Member

All notebooks run through without error on this branch (c375d48) and there seem to be no unexpected differences in output (to me as a non-expert). I did not check for any performance regression.

@benlorenz benlorenz marked this pull request as ready for review July 3, 2024 22:07
@benlorenz benlorenz merged commit 27ec7aa into release-1.1 Jul 3, 2024
30 checks passed
@benlorenz benlorenz deleted the backports-release-1.1 branch July 3, 2024 22:11
@fingolfin
Copy link
Member

Thank you @benlorenz your efforts are much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants