Some serialization of schemes #4110
Draft
+861
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HechtiDerLachs
force-pushed
the
localization_serialization
branch
from
338cfa7
to
7ac8e7d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4110 +/- ##
==========================================
+ Coverage 84.67% 84.71% +0.03%
==========================================
Files 626 627 +1
Lines 83980 84176 +196
==========================================
+ Hits 71108 71306 +198
+ Misses 12872 12870 -2
|
Comment on lines
36
to
41
| @check begin | ||
| d = prod(length(f) > 0 ? f : one(OO(X))) | ||
| U = spec(R) | ||
| U == hypersurface_complement(X, d) | ||
| end | ||
| return new{base_ring_type(X), ring_type(U), typeof(X)}(X, U, lifted_numerator.(f)) |
There was a problem hiding this comment.
this looks fishy to me. U is not defined if check=false
There was a problem hiding this comment.
You're right. I'll look into this.
HechtiDerLachs
force-pushed
the
localization_serialization
branch
from
1a9a316
to
5e4398d
Compare
HechtiDerLachs
commented
Sep 20, 2024
test/Serialization/IPC.jl
Outdated
Comment on lines
30
to
48
| @testset "parallel smoothness test for schemes" begin | ||
| channels = Oscar.params_channels(Union{AffineScheme, Ring}) | ||
|
|
||
| IP2 = projective_space(QQ, [:x, :y, :z]) | ||
| S = homogeneous_coordinate_ring(IP2) | ||
| (x, y, z) = gens(S) | ||
|
|
||
| I = ideal(S, y^2*z + x^3 + x^2*z) | ||
|
|
||
| X, _ = sub(IP2, I) | ||
| X_cov = covered_scheme(X) | ||
| U = affine_charts(X_cov) | ||
| for a in U | ||
| Oscar.put_params(channels, ambient_coordinate_ring(a)) | ||
| Oscar.put_params(channels, OO(a)) | ||
| end | ||
| results = pmap(is_smooth, U) | ||
| @test results == [1, 1, 0] | ||
| end |
There was a problem hiding this comment.
ping @simonbrandhorst , @afkafkafk13 .
|
Can we merge #4121 first and then get a better view on what's going on here? It seems that this is built on top of the other. |
HechtiDerLachs
force-pushed
the
localization_serialization
branch
from
bc12d64
to
6ccadd7
Compare
|
@antonydellavecchia : I did another implementation which broadcasts all rings to all workers using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intermediate state of the art of our joint effort with @antonydellavecchia this week.