Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove anonymous functions from sheaves #4121

Merged
merged 4 commits into from
Sep 20, 2024

Address comments from review.

240be1e
Select commit
Loading
Failed to load commit list.
Merged

Remove anonymous functions from sheaves #4121

Address comments from review.
240be1e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Sep 20, 2024 in 1s

76.36% of diff hit (target 84.65%)

View this Pull Request on Codecov

76.36% of diff hit (target 84.65%)

Annotations

Check warning on line 36 in src/AlgebraicGeometry/Schemes/PrincipalOpenSubset/Objects/Types.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/PrincipalOpenSubset/Objects/Types.jl#L36 

Added line #L36 was not covered by tests

Check warning on line 630 in src/AlgebraicGeometry/Schemes/Sheaves/CoherentSheaves.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/Sheaves/CoherentSheaves.jl#L630 

Added line #L630 was not covered by tests

Check warning on line 716 in src/AlgebraicGeometry/Schemes/Sheaves/CoherentSheaves.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/Sheaves/CoherentSheaves.jl#L716 

Added line #L716 was not covered by tests

Check warning on line 63 in src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl#L63 

Added line #L63 was not covered by tests

Check warning on line 87 in src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl#L87 

Added line #L87 was not covered by tests

Check warning on line 111 in src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl#L111 

Added line #L111 was not covered by tests

Check warning on line 130 in src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl#L130 

Added line #L130 was not covered by tests

Check warning on line 147 in src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl#L146-L147 

Added lines #L146 - L147 were not covered by tests

Check warning on line 184 in src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl#L182-L184 

Added lines #L182 - L184 were not covered by tests

Check warning on line 205 in src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl#L205 

Added line #L205 was not covered by tests

Check warning on line 211 in src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl#L209-L211 

Added lines #L209 - L211 were not covered by tests

Check warning on line 215 in src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl#L214-L215 

Added lines #L214 - L215 were not covered by tests

Check warning on line 225 in src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl#L219-L225 

Added lines #L219 - L225 were not covered by tests

Check warning on line 229 in src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl#L228-L229 

Added lines #L228 - L229 were not covered by tests

Check warning on line 233 in src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl#L233 

Added line #L233 was not covered by tests

Check warning on line 239 in src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl#L239 

Added line #L239 was not covered by tests

Check warning on line 248 in src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl#L248 

Added line #L248 was not covered by tests

Check warning on line 309 in src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl#L309 

Added line #L309 was not covered by tests

Check warning on line 370 in src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl#L370 

Added line #L370 was not covered by tests

Check warning on line 373 in src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl#L372-L373 

Added lines #L372 - L373 were not covered by tests

Check warning on line 387 in src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl#L379-L387 

Added lines #L379 - L387 were not covered by tests

Check warning on line 392 in src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl#L390-L392 

Added lines #L390 - L392 were not covered by tests

Check warning on line 433 in src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl#L433 

Added line #L433 was not covered by tests

Check warning on line 436 in src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl#L435-L436 

Added lines #L435 - L436 were not covered by tests

Check warning on line 450 in src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/Sheaves/Methods.jl#L442-L450 

Added lines #L442 - L450 were not covered by tests
View more details on Codecov