Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump AA, Nemo, and Hecke compat #4122

Merged
merged 7 commits into from
Sep 20, 2024
Merged

Conversation

lgoettgens
Copy link
Member

Still waiting for a Hecke release.

@lgoettgens

This comment was marked as resolved.

@lgoettgens lgoettgens closed this Sep 19, 2024
@lgoettgens lgoettgens reopened this Sep 19, 2024
src/Rings/AbelianClosure.jl Outdated Show resolved Hide resolved
@fingolfin
Copy link
Member

The changes in straight line programs lead to test failures. Haven't yet tried to understand why, need sleep

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 85.41667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 84.67%. Comparing base (639d5be) to head (8469b36).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/Rings/AbelianClosure.jl 76.47% 4 Missing ⚠️
src/StraightLinePrograms/straightline.jl 80.00% 2 Missing ⚠️
experimental/GModule/src/GaloisCohomology.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4122      +/-   ##
==========================================
- Coverage   84.67%   84.67%   -0.01%     
==========================================
  Files         626      626              
  Lines       84265    84249      -16     
==========================================
- Hits        71353    71334      -19     
- Misses      12912    12915       +3     
Files with missing lines Coverage Δ
experimental/GModule/test/runtests.jl 100.00% <ø> (ø)
experimental/Schemes/src/Resolution_tools.jl 88.77% <100.00%> (ø)
src/InvariantTheory/invariant_rings.jl 90.96% <100.00%> (ø)
src/NumberTheory/GaloisGrp/GaloisGrp.jl 78.61% <ø> (+0.03%) ⬆️
src/Rings/MPolyQuo.jl 91.99% <100.00%> (ø)
src/Rings/NumberField.jl 90.16% <ø> (-0.07%) ⬇️
src/Rings/localization_interface.jl 61.08% <ø> (-2.38%) ⬇️
src/Rings/mpoly-graded.jl 91.44% <ø> (-0.04%) ⬇️
src/Rings/mpolyquo-localizations.jl 72.91% <ø> (-0.07%) ⬇️
src/Rings/slpolys.jl 86.61% <100.00%> (ø)
... and 6 more

Project.toml Outdated Show resolved Hide resolved
experimental/GModule/src/GaloisCohomology.jl Outdated Show resolved Hide resolved
experimental/GModule/src/GaloisCohomology.jl Outdated Show resolved Hide resolved
experimental/GModule/src/GaloisCohomology.jl Outdated Show resolved Hide resolved
experimental/GModule/src/GaloisCohomology.jl Outdated Show resolved Hide resolved
experimental/GModule/test/runtests.jl Outdated Show resolved Hide resolved
@lgoettgens lgoettgens marked this pull request as ready for review September 20, 2024 11:35
@fingolfin fingolfin enabled auto-merge (squash) September 20, 2024 11:37
@fingolfin fingolfin merged commit 84c42c9 into oscar-system:master Sep 20, 2024
28 checks passed
@lgoettgens lgoettgens deleted the lg/dep-bump branch September 20, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants