Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of trivial anonymous functions (part 1) #4126

Merged
merged 20 commits into from
Sep 20, 2024

Conversation

lgoettgens
Copy link
Member

(Splitting this up to try to prevent too many conflicts.

This should increase compilation times, in particular re-compilation.

The problem of anonymous functions is that each one of them has its own type. If we now pass it to a function (or even worse, to a parameterized type), all functions below have to get re-compiled for this new type.
This PR only touches really trivial cases, where readability of the code should still be similar as before.

@fingolfin fingolfin enabled auto-merge (squash) September 20, 2024 11:41
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 82.55814% with 15 lines in your changes missing coverage. Please review.

Project coverage is 84.67%. Comparing base (2dc5df5) to head (da244d9).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...xperimental/FTheoryTools/src/TateModels/methods.jl 40.00% 3 Missing ⚠️
...leAndHyperComplexes/src/Objects/total_complexes.jl 33.33% 2 Missing ⚠️
experimental/GModule/src/GaloisCohomology.jl 33.33% 2 Missing ⚠️
.../FTheoryTools/src/LiteratureModels/create_index.jl 0.00% 1 Missing ⚠️
experimental/FTheoryTools/src/auxiliary.jl 80.00% 1 Missing ⚠️
experimental/GaloisGrp/src/Solve.jl 0.00% 1 Missing ⚠️
experimental/LieAlgebras/src/LieAlgebra.jl 0.00% 1 Missing ⚠️
experimental/ModStd/src/ModStdNF.jl 0.00% 1 Missing ⚠️
experimental/OrthogonalDiscriminants/src/data.jl 0.00% 1 Missing ⚠️
.../QuadFormAndIsom/src/hermitian_miranda_morrison.jl 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4126   +/-   ##
=======================================
  Coverage   84.67%   84.67%           
=======================================
  Files         626      625    -1     
  Lines       84249    84256    +7     
=======================================
+ Hits        71340    71347    +7     
  Misses      12909    12909           
Files with missing lines Coverage Δ
...l/AlgebraicStatistics/src/PhylogeneticAuxiliary.jl 77.77% <100.00%> (ø)
...braicStatistics/src/PhylogeneticParametrization.jl 96.80% <100.00%> (ø)
...ental/DoubleAndHyperComplexes/src/Morphisms/ext.jl 97.57% <100.00%> (ø)
...eAndHyperComplexes/src/Morphisms/linear_strands.jl 95.23% <100.00%> (ø)
...perComplexes/src/Morphisms/simplified_complexes.jl 94.61% <100.00%> (ø)
...ental/DoubleAndHyperComplexes/src/Objects/Types.jl 72.12% <100.00%> (ø)
.../FTheoryTools/src/AbstractFTheoryModels/methods.jl 78.27% <100.00%> (ø)
...tal/FTheoryTools/src/HypersurfaceModels/methods.jl 100.00% <100.00%> (ø)
.../FTheoryTools/src/LiteratureModels/constructors.jl 93.81% <100.00%> (ø)
...mental/FTheoryTools/src/TateModels/constructors.jl 97.46% <100.00%> (ø)
... and 37 more

... and 4 files with indirect coverage changes

@fingolfin fingolfin merged commit 98f11e5 into oscar-system:master Sep 20, 2024
28 checks passed
@lgoettgens lgoettgens deleted the lg/anonymus-functions branch September 20, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants