Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to Singular_jll v403.214.1400 #748

Merged
merged 5 commits into from
Jan 19, 2024

Conversation

hannes14
Copy link
Member

No description provided.

deps/src/ideals.cpp Outdated Show resolved Hide resolved
deps/src/ideals.cpp Outdated Show resolved Hide resolved
@fingolfin
Copy link
Member

@hannes14 just for the record, you can test these changes (in particular to see if they have syntax errors) locally... just dev the package and do using Singular

@fingolfin
Copy link
Member

Oscar.jl tests fail, but I hope it's a fluke... CC @ThomasBreuer we see this in the logs:

┌ Error: doctest failure in ~/.julia/packages/Oscar/1Moid/src/Groups/libraries/atlasgroups.jl:276-285
│ 
│ ```jldoctest
│ julia> number_atlas_groups("A5")
│ 18
│ 
│ julia> number_atlas_groups(PermGroup, "A5")
│ 3
│ 
│ julia> number_atlas_groups(MatrixGroup, "A5")
│ 15
│ 
│ ```
│ 
│ Subexpression:
│ 
│ number_atlas_groups("A5")
│ 
│ Evaluated output:
│ 
│ ERROR: Error thrown by GAP: Error, FuncAPPEND_LIST_INTR: <list2> must be a small list (not a character) in
│   Append( res, arg[i] ); at /home/runner/.julia/artifacts/b5c2f0f824457e5c391fb24916f94d5d91c62c4f/share/gap/lib/list.gi:2086 called from
│ Concatenation( JoinStringsWithSeparator( tocid, "|" ), "|", gapname ) at /home/runner/.julia/scratchspaces/c863536a-3901-11e9-33e7-d5cd0df7b904/gap_4855902246029889253_1.9/pkg/atlasrep/gap/interfac.gi:897 called from
│ AGR.MergedTableOfContents( tocid, gapname ) at /home/runner/.julia/scratchspaces/c863536a-3901-11e9-33e7-d5cd0df7b904/gap_4855902246029889253_1.9/pkg/atlasrep/gap/interfac.gi:1241 called from
│ AGR.AtlasGeneratingSetInfo( arg, "all" ) at /home/runner/.julia/scratchspaces/c863536a-3901-11e9-33e7-d5cd0df7b904/gap_4855902246029889253_1.9/pkg/atlasrep/gap/interfac.gi:1324 called from
│ <function "AllAtlasGeneratingSetInfos">( <arguments> )
│  called from read-eval loop at *defin*:0
│ 
│ Stacktrace:
│  [1] error(s::String)
│    @ Base ./error.jl:35
│  [2] ThrowObserver(depth::Int32)
│    @ GAP ~/.julia/packages/GAP/aJO9M/src/GAP.jl:89
│  [3] _call_gap_func
│    @ ~/.julia/packages/GAP/aJO9M/src/ccalls.jl:325 [inlined]
│  [4] (::GAP.GapObj)(a1::GAP.GapObj)
│    @ GAP ~/.julia/packages/GAP/aJO9M/src/ccalls.jl:302
│  [5] number_atlas_groups(name::String)
│    @ Oscar ~/.julia/packages/Oscar/1Moid/src/Groups/libraries/atlasgroups.jl:289
│  [6] top-level scope
│    @ none:1
│ 

I'll restart that CI job

@ederc
Copy link
Member

ederc commented Jan 19, 2024

@fingolfin I looked into this error, but I could not see any connection to this PR. Let's see what happens for the restarted checks.

@ThomasBreuer
Copy link
Member

Concerning the error messages, I have no idea yet what happens:
JoinStringsWithSeparator has been successful, and Concatenation would output the shown error message if the argument gapname would be a character. But how can I get into this situation by calling AGR.AtlasGeneratingSetInfo?

@fingolfin fingolfin merged commit 34df715 into oscar-system:master Jan 19, 2024
13 of 14 checks passed
@hannes14 hannes14 deleted the hs/libsingular branch January 19, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants