Add patches for kolla-operations deployment #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add patches to support deployment of kolla-operations resources from the
kolla-ansible container.
Subject: [PATCH 1/4] Fix redundant extra config files in grafana role
Task `Check if extra configuration file exists` picks up all files in
`{{ node_custom_config }}/grafana` including those that get handled
specially later on.
While `prometheus.yml` and `provisioning.yml` are best excluded from
extra config , because their treatment requires more than just copying,
`grafana_home_dashboard.json` may simply be treated as extra config,
which saves the execution of two additional tasks..
Subject: [PATCH 2/4] Improve grafana dashboard deployment
Unitl now grafana dashboards were always removed and redeployed leading
to a restart of the grafana services on every deployment.
The task is changed to find all individual dashboards that are going to
be deployed and all which are currently deployed. Dashboards only
appearing in the latter group wil be removed, while dashboards in the
former group will be deployed individually, leaving it to ansible to
figure which changes need to be made.
This way only removal or changes to dashboards will lead to a restart of
grafana containers.
Subject: [PATCH 3/4] Allow extension of grafana override paths
Subject: [PATCH 4/4] Allow extension of prometheus override paths
Part of osism/issues#1012
Signed-off-by: Jan Horstmann <horstmann@osism.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add patches to support deployment of kolla-operations resources from the kolla-ansible container.
Subject: [PATCH 1/4] Fix redundant extra config files in grafana role
Task
Check if extra configuration file existspicks up all files in{{ node_custom_config }}/grafanaincluding those that get handled specially later on.While
prometheus.ymlandprovisioning.ymlare best excluded from extra config , because their treatment requires more than just copying,grafana_home_dashboard.jsonmay simply be treated as extra config, which saves the execution of two additional tasks..Subject: [PATCH 2/4] Improve grafana dashboard deployment
Unitl now grafana dashboards were always removed and redeployed leading to a restart of the grafana services on every deployment. The task is changed to find all individual dashboards that are going to be deployed and all which are currently deployed. Dashboards only appearing in the latter group wil be removed, while dashboards in the former group will be deployed individually, leaving it to ansible to figure which changes need to be made.
This way only removal or changes to dashboards will lead to a restart of grafana containers.
Subject: [PATCH 3/4] Allow extension of grafana override paths
Subject: [PATCH 4/4] Allow extension of prometheus override paths
Part of osism/issues#1012