Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action to build wheels for windows and mac #5

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

fccoelho
Copy link
Collaborator

@fccoelho fccoelho commented Oct 8, 2022

The build is still failing because on windows there is no header unistd.h which is included on line 32 of dbc2dbf.c.
I found this comment about this problem: https://stackoverflow.com/questions/22705751/cannot-open-include-file-unistd-h-no-such-file-or-directory

@xmnlab
Copy link
Member

xmnlab commented Oct 8, 2022

That makes total sense

@esloch
Copy link
Contributor

esloch commented Oct 8, 2022

Isn't it necessary to use tool.cibuildwheel in pyproject.toml?

@fccoelho
Copy link
Collaborator Author

Isn't it necessary to use tool.cibuildwheel in pyproject.toml?

According to the [documentation] this is not required.

@fccoelho
Copy link
Collaborator Author

@esloch scipy uses these scripts to install certain headers that are missing on windows, which is just what we need to do, however, I am not sure how to install additional libraries in the windows CI image before the build. It seem that what we need is this: https://github.com/robinrowe/libunistd

@fccoelho
Copy link
Collaborator Author

Now it is hitting another compilation error. Debugging the Windows build over CI is going to take a long time.
It would be easier to do this from a windows box.

@fccoelho fccoelho mentioned this pull request May 16, 2023
@xmnlab
Copy link
Member

xmnlab commented May 7, 2024

is still the windows build necessary?
maybe it would be better to just recommend to users to use WSL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants