Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix "hu" (shop/convenience|Abc) - general hungarian word - remove (need extra check in Poland!) #2087

Closed
wants to merge 1 commit into from
Closed

fix "hu" (shop/convenience|Abc) - general hungarian word - remove (need extra check in Poland!) #2087

wants to merge 1 commit into from

Conversation

ImreSamu
Copy link
Contributor

No description provided.

@ImreSamu ImreSamu changed the title fix "hu" (shop/convenience|Abc) - general hungarian word - remove fix "hu" (shop/convenience|Abc) - general hungarian word - remove ( need extra check check in Poland! ) Oct 21, 2018
@matthijsmelissen
Copy link
Collaborator

Why you think 'ABC' is a generic hungarian word?

At least in Poland, ABC (or Abc or abc, not sure) is a major chain of small convenience shops.

@ImreSamu
Copy link
Contributor Author

Why you think 'ABC' is a generic hungarian word?

in Hungary, it is a synonym for a ( food ) shop ( ~ type of shop ) - so a general name.

maybe you can re-add with proper country code + wikidata code

@ImreSamu
Copy link
Contributor Author

Google Translate link:ABC Áruház

@ImreSamu
Copy link
Contributor Author

Overpass Turbo : http://overpass-turbo.eu/s/CYa

@ImreSamu
Copy link
Contributor Author

wordwide Overpass Turbo : it is a frequent name.
image

@ImreSamu ImreSamu mentioned this pull request Oct 21, 2018
Closed
@bhousel
Copy link
Member

bhousel commented Oct 21, 2018

Ah yeah this is another tricky one kind of like Price Chopper #1868
There's one in Hawaii too: https://en.wikipedia.org/wiki/ABC_Stores_(Hawaii)

Let's leave this open but hold off on merging for now..

@good-praxis good-praxis mentioned this pull request Oct 22, 2018
Open
@good-praxis good-praxis changed the title fix "hu" (shop/convenience|Abc) - general hungarian word - remove ( need extra check check in Poland! ) fix "hu" (shop/convenience|Abc) - general hungarian word - remove (need extra check in Poland! ) Oct 22, 2018
@good-praxis good-praxis changed the title fix "hu" (shop/convenience|Abc) - general hungarian word - remove (need extra check in Poland! ) fix "hu" (shop/convenience|Abc) - general hungarian word - remove (need extra check in Poland!) Oct 22, 2018
@matkoniecz
Copy link
Contributor

There's one in Hawaii too: https://en.wikipedia.org/wiki/ABC_Stores_(Hawaii)

Article for Polish brand is at https://pl.wikipedia.org/wiki/Abc_(sie%C4%87_handlowa) ( https://www.wikidata.org/wiki/Q11683985 )

matkoniecz added a commit that referenced this pull request Nov 3, 2018
@matkoniecz
attempt to handle convenience shops named abc
da5c7ca 
closes #2087
@matkoniecz matkoniecz mentioned this pull request Nov 3, 2018
Merged
@ImreSamu ImreSamu deleted the fix_hu_abc branch January 4, 2019 12:36
@ImreSamu ImreSamu mentioned this pull request Jan 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ImreSamu @matthijsmelissen @bhousel @matkoniecz @good-praxis