Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Greyhound bus lines (US) #2863

Closed
wants to merge 1 commit into from
Closed

Add Greyhound bus lines (US) #2863

wants to merge 1 commit into from

Conversation

quincylvania
Copy link
Contributor

Inspired by discussion in #2846, I'd like to see what people think about adding branded transit stops/stations. I think it'd be useful, especially for data consumers focused on public transport routing.

The main obstacle I see is that a single transit station can sometimes be used by multiple carriers. Another obstacle is that this index can only filter geographically on a country-wide basis, while most transit brands are just city-wide.

I'm starting with Greyhound since they're national and tend to run their own stations.

@quincylvania quincylvania requested a review from bhousel July 9, 2019 15:33
"bus": "yes",
"name": "Greyhound Station",
"name:en": "Greyhound Station",
"public_transport": "station"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to add a short name of just Greyound here so we get that as a matcher. Also thanks for doing this one. I have a note with all the brands I run across that need an entry and this was in it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also there's Greyhound Canada that might be worth adding while you're in this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name matcher only matches against features with the base tags, right? There could be various bars or other places called just "Greyhound".

And yes, we should add the other Greyhound subsidiaries once this is merged.

Copy link
Member

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really excited to start working on a canonical list of public transportation operators! Given the difference in tagging, coverage tracking, and well, purpose, what do you think about moving this listing to a new networks/ folder? We’ll need to upgrade some infrastructure in this project and downstream to cope with the new folder, but I think clients would need to handle these entries differently than brands anyhow.

"tags": {
"amenity": "bus_station",
"brand": "Greyhound Lines",
"brand:wikidata": "Q755309",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OSM uses network and operator tags for public transportation facilities, both of which come with :wikidata subkeys as well. I suppose brand would indicate a relationship such as Ford sponsoring the GoBike program in the San Francisco Bay Area, but that’s much less important than capturing the network and operator.

@@ -0,0 +1,16 @@
{
"public_transport/station|Greyhound Station": {
"countryCodes": ["us"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Luckily, Greyhound happens to be a national carrier. But as we continue to add public transportation providers, we’re going to run into lots of conflicts across states. Unlike with brands and even banks, most public transportation operators are confined to a single state and their state coverage is quite stable. So we’ll need a way to track ISO 3166 subnational codes, not just country codes, even if we don’t happen to use it for Greyhound.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. We don't want Los Angeles bus stops to be recommended in Boston.

@quincylvania
Copy link
Contributor Author

Given the difference in tagging, coverage tracking, and well, purpose, what do you think about moving this listing to a new networks/ folder?

@1ec5 Interesting idea, but I don't see harm in continuing to use the brand tag (and folder) for these for consistency. When I walk into a BART station I'd certainly say it's "branded" as a BART station.

Adding network and network:wikidata sounds fine since they're already in use. The operator and operator:wikidata could be okay if there aren't any exceptions for the given transit provider.

I think clients would need to handle these entries differently than brands anyhow.

Some clients might, but not all of them, and probably not iD. My own preference is to avoid fragmentation.

What do you think, @bhousel?

@1ec5
Copy link
Member

1ec5 commented Jul 9, 2019

Interesting idea, but I don't see harm in continuing to use the brand tag (and folder) for these for consistency. When I walk into a BART station I'd certainly say it's "branded" as a BART station.

I definitely see similarity between BART station signage and retail branding. But at least in the U.S., that isn’t often or even usually the case with public transportation operators:

  • In Cincinnati, some bus stops have Metro signs, but other bus stops are marked by nothing but a blazer (a red stripe painted on a telephone pole). This stop outside a Greyhound station has both, but you get the idea.
  • Blazers were the norm across the U.S. until 10–15 years ago. San Francisco Muni mostly switched over to signs in 2015, but some lone blazers remain.
  • In San José (which will have a BART station someday 🤞), VTA bus stations do have retail-style branding, but all the bus stop signs just have generic “Bus Stop” signs. Unless there’s a VTA-branded shelter, you practically have to walk up and squint to see any mention of VTA.

Meanwhile, Greyhound shuttered its San José station in favor of sharing facilities at a VTA bus station. You only find the Greyhound logo on the buses themselves. It would be appropriate to include Greyhound in Diridon Station’s network tag, but it would be inappropriate to add a brand tag for it. I wouldn’t be surprised if discount intercity lines like Megabus are forcing them to colocate in other cities too. (Megabus stops are far less expensive to operate. The San Francisco stop consists of nothing more than the driver standing on the sidewalk, holding up a sign, when he isn’t busy helping customers.)

I don’t see much harm in tagging the more built-out Greyhound stations with brand, or those of any private intercity line for that matter. But I’m eager to see NSI grow beyond branding, so that it can be more useful to data consumers. Going back to the original post:

I think it'd be useful, especially for data consumers focused on public transport routing.

Maybe brand could distinguish between signposted and unsignposted stops, but that distinction would only maybe be meaningful to renderers. It’d be much more important for routers and search engines that network be consistent across all the stops in a network, regardless of build quality, and even more important that the routes are properly tagged.

Given that network contains abbreviations, some of which are nonobvious and few of which are unique, NSI would have an important role to play in helping mappers and routers make sense of it all. If I were building public transportation routing, I’d want to support network:wikidata rather than have to perform spatial queries just to figure out what “RTA” means in a given city. A network/ folder could also be a place to compile presets for road and cycle route networks, few of which have any branding per se.

I think clients would need to handle these entries differently than brands anyhow.

Some clients might, but not all of them, and probably not iD. My own preference is to avoid fragmentation.

To expand on this point, iD would also need to implement suggestions for the Network field, similar to what exists for Name today. Bus stops would need to be matched on the network tag, not name or brand. (Bus stops may be named, but the network is relatively seldom included in the name, so including it in a preset would be incorrect.)

Admittedly, adding actual support for public transportation networks would be well beyond the original scope of this PR. So I’m not sure how you’d all like to proceed, but I hope we can continue this conversation.

@bhousel
Copy link
Member

bhousel commented Jul 9, 2019

What do you think, @bhousel?

I think OSM convention for transit is to use operator/operator:wikidata and network tags like @1ec5 said. We have to follow it, even if it makes more work for us. I thought about this a bit in #2243 (comment)

It would be cleanest to start a new tree for them outside of brands/. It would also require some code changes to the project, but nothing too onerous. For example we're excluding operator tags from the brands, but we'd include that tag in the public transit tree, so we'd need a different json schema to validate the entries there. And like mentioned above we'd need to handle regions better - country isn't granular enough.

@quincylvania
Copy link
Contributor Author

@1ec5 @bhousel Sounds good. Thanks for taking the time to respond and for bearing with me. I've only been tangentially involved in this project so I've missed plenty of discussion like #2243.

Closing this so we can focus on a more comprehensive solution 👍

@quincylvania quincylvania removed the request for review from bhousel July 9, 2019 19:14
@tas50
Copy link
Contributor

tas50 commented Jul 9, 2019

Oh man I'm that user responding to a closed user now, but would Greyhound be considered a public transit system that should be tagged like one? There's no public funding there. It's just a private business that has private business locations, which seems like it's a brand, which would fit nicely into the existing tagging structure.

@1ec5
Copy link
Member

1ec5 commented Jul 9, 2019

Yeah, that’s why I mentioned that it’s OK to use brand for Greyhound. It’s a retail establishment specializing in intercity transportation, just as the various amenity=kindergarten entries in this index are retail establishments specializing in early childhood education. As far as transportation goes, I think Greyhound is an edge case that we can include in the index, but I don’t think it should set a precedent for other bus operators. Regardless, the entry does need a network tag.

@1ec5
Copy link
Member

1ec5 commented Jul 9, 2019

#2864 tracks expanding the scope of this project to include public transportation networks.

@quincylvania quincylvania deleted the greyhound-us branch July 26, 2019 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants