-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Greyhound bus lines (US) #2863
Conversation
"bus": "yes", | ||
"name": "Greyhound Station", | ||
"name:en": "Greyhound Station", | ||
"public_transport": "station" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to add a short name of just Greyound here so we get that as a matcher. Also thanks for doing this one. I have a note with all the brands I run across that need an entry and this was in it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also there's Greyhound Canada that might be worth adding while you're in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name matcher only matches against features with the base tags, right? There could be various bars or other places called just "Greyhound".
And yes, we should add the other Greyhound subsidiaries once this is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really excited to start working on a canonical list of public transportation operators! Given the difference in tagging, coverage tracking, and well, purpose, what do you think about moving this listing to a new networks/ folder? We’ll need to upgrade some infrastructure in this project and downstream to cope with the new folder, but I think clients would need to handle these entries differently than brands anyhow.
"tags": { | ||
"amenity": "bus_station", | ||
"brand": "Greyhound Lines", | ||
"brand:wikidata": "Q755309", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OSM uses network
and operator
tags for public transportation facilities, both of which come with :wikidata
subkeys as well. I suppose brand
would indicate a relationship such as Ford sponsoring the GoBike program in the San Francisco Bay Area, but that’s much less important than capturing the network and operator.
@@ -0,0 +1,16 @@ | |||
{ | |||
"public_transport/station|Greyhound Station": { | |||
"countryCodes": ["us"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Luckily, Greyhound happens to be a national carrier. But as we continue to add public transportation providers, we’re going to run into lots of conflicts across states. Unlike with brands and even banks, most public transportation operators are confined to a single state and their state coverage is quite stable. So we’ll need a way to track ISO 3166 subnational codes, not just country codes, even if we don’t happen to use it for Greyhound.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. We don't want Los Angeles bus stops to be recommended in Boston.
@1ec5 Interesting idea, but I don't see harm in continuing to use the Adding
Some clients might, but not all of them, and probably not iD. My own preference is to avoid fragmentation. What do you think, @bhousel? |
I definitely see similarity between BART station signage and retail branding. But at least in the U.S., that isn’t often or even usually the case with public transportation operators:
Meanwhile, Greyhound shuttered its San José station in favor of sharing facilities at a VTA bus station. You only find the Greyhound logo on the buses themselves. It would be appropriate to include Greyhound in Diridon Station’s I don’t see much harm in tagging the more built-out Greyhound stations with
Maybe Given that
To expand on this point, iD would also need to implement suggestions for the Network field, similar to what exists for Name today. Bus stops would need to be matched on the Admittedly, adding actual support for public transportation networks would be well beyond the original scope of this PR. So I’m not sure how you’d all like to proceed, but I hope we can continue this conversation. |
I think OSM convention for transit is to use It would be cleanest to start a new tree for them outside of |
Oh man I'm that user responding to a closed user now, but would Greyhound be considered a public transit system that should be tagged like one? There's no public funding there. It's just a private business that has private business locations, which seems like it's a brand, which would fit nicely into the existing tagging structure. |
Yeah, that’s why I mentioned that it’s OK to use |
#2864 tracks expanding the scope of this project to include public transportation networks. |
Inspired by discussion in #2846, I'd like to see what people think about adding branded transit stops/stations. I think it'd be useful, especially for data consumers focused on public transport routing.
The main obstacle I see is that a single transit station can sometimes be used by multiple carriers. Another obstacle is that this index can only filter geographically on a country-wide basis, while most transit brands are just city-wide.
I'm starting with Greyhound since they're national and tend to run their own stations.