Add new ATM category

[mds08011]

This is a draft pull request related to adding ATMs to the NSI as discussed in #2883 . Still a work in progress. Feedback is welcome as are any changes.

[andrewharvey]

Since most banks with a store would have an ATM, it's it worth bootstrapping this by copying amenity=bank and then any tweaks can be made from there?

[mds08011]

The initial intent was to focus on banks known for having freestanding ATMs. While it’s true that most banks would have ATMs attached to the bank location, not all have them have a network of separate ATMs. I’m hesitant that bootstrapping banks will bring too many excess entries.

[andrewharvey]

No worries, looks good to me, which part is still a WIP? I'd like to add Australian ATMs, but would be best if this get merged first to avoid conflicts..

[mds08011]

@andrewharvey overall we are trying to work through how to best use name, brand, operator, and network tags.

You can see more discussion here: #2883

[anandfresh]

I feel the amenity property is redundant. Can we do some JSON refactoring to avoid redundancy and to keep the common values ahead
"amenity": "atm",

[bhousel]

These are redundant only because we group them into files by this property key=value pair. The property is important as an OpenStreetMap tag, so it must stay.

[anandfresh]

But do we have any plan to refractor this JSON/app in near future?

[bhousel]

No plans, I’m pretty happy with the JSON structure.

[UKChris-osm]

Not sure how this draft is going, or if this entry would be suitable, but below is an entry for Sainsbury's Bank ATM's.

"amenity/atm|Sainsbury's Bank": {
"countryCodes": ["gb"],
"tags": {
"amenity": "atm",
"brand": "Sainsbury's Bank",
"brand:wikidata": "Q7400525",
"brand:wikipedia": "en:Sainsbury's Bank",
"name": "Sainsbury's Bank",
"network": "Link",
"network:wikidata": "Q6458752",
"network:wikipedia": "en:Link (UK)"
}
}

Sainsbury's doesn't have any conventional bank locations, just ATM's at Sainsbury's and Argos stores, as well as some travel money counters, so that might make this entry more aligned with the freestanding ATM concept mentioned above.

[bhousel]

Going to close this for now.

Restructuring the code to allow operator or network to be the the defining tag (instead of brand) is in the back of my mind and will happen eventually.