refactor: syncronize pruning manager #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tely when updated in memory; unit tests
p0mvn
commented
Apr 12, 2022
| require.NotNil(t, manager) | ||
|
|
||
| manager.SetOptions(types.NewPruningOptions(types.PruningNothing)) | ||
|
|
||
| require.Nil(t, manager.LoadPruningHeights(db.NewMemDB())) | ||
| } | ||
|
|
||
| func TestWithSnapshot(t *testing.T) { |
There was a problem hiding this comment.
With 2 locks, this is not possible to reproduce anymore
19 tasks
…h error, fix logs
|
All comments are addressed |
alexanderbez
approved these changes
Apr 12, 2022
p0mvn
added a commit
that referenced
this pull request
Apr 13, 2022
* progress * refactor pruning manager to have no data races; flush heights immediately when updated in memory; unit tests * typo in TestMultiStore_PruningRestart * fmt * improve comments * avoid mutex init, move comments to struct declaration, return nil with error, fix logs
p0mvn
added a commit
that referenced
this pull request
Apr 20, 2022
* progress * refactor pruning manager to have no data races; flush heights immediately when updated in memory; unit tests * typo in TestMultiStore_PruningRestart * fmt * improve comments * avoid mutex init, move comments to struct declaration, return nil with error, fix logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow-up to: cosmos#11496 (comment)
It mitigates the risk of soundness bugs / data races by synchronizing access to all members of the pruning manager and making some operations atomic. For example, GetHeights, FlushHeights and ResetHeights was merged into one
GetFlushAndResetPruningHeights.In addition, it addresses another previously known issue: #149
Updated unit tests to reflect all changes. Also, added a unit test to attempt pruning the same heights twice.