Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Swagger #2233

Closed
2 tasks
mattverse opened this issue Jul 25, 2022 · 3 comments · Fixed by #2271
Closed
2 tasks

Update Swagger #2233

mattverse opened this issue Jul 25, 2022 · 3 comments · Fixed by #2271
Assignees
@ctrl-Felix

Comments

@mattverse
Copy link
Member

Background

Currently swagger has been long out of date, the main reason for this is that the current scripts(make file and script file in charge of generating docs) has broken directory settings for swagger, thus has not been generating updated swagger files. This should get fixed so that the docs script updates swagger up-to-date and we have an updated version of swagger.yaml

Acceptance Criteria

  • Fix docs gen script so that it correctly generates updated swagger on make docs run.
  • Have the swagger file up to date with the most recent proto
@ctrl-Felix
Copy link
Contributor

ctrl-Felix commented Jul 26, 2022 •
edited
Loading

I've looked into it and I think I can provide a fix

@mattverse
Copy link
Member Author

Awesome! Feel free to shoot up a PR whenever ready!

@ctrl-Felix ctrl-Felix mentioned this issue Aug 2, 2022
Merged
@ctrl-Felix
Copy link
Contributor

Alright. PR is created!

p0mvn pushed a commit that referenced this issue Aug 3, 2022
@ctrl-Felix
fix: swagger docs & swagger generation #2233 (#2271)
1592bb8
mergify bot pushed a commit that referenced this issue Aug 3, 2022
@ctrl-Felix @mergify
fix: swagger docs & swagger generation #2233 (#2271)
e6de010 
(cherry picked from commit 1592bb8)
p0mvn pushed a commit that referenced this issue Aug 3, 2022
@mergify @ctrl-Felix
fix: swagger docs & swagger generation #2233 (#2271) (#2288)
681ffae 
(cherry picked from commit 1592bb8)

Co-authored-by: Felix <62290842+ctrl-Felix@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ctrl-Felix ctrl-Felix

Labels
None yet
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: swagger docs & swagger generation #2233
2 participants
@mattverse @ctrl-Felix