Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move random genesis to an extension interface #2081

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Move random genesis to an extension interface #2081

merged 1 commit into from
Jul 15, 2022

Conversation

ValarDragon
Copy link
Member

## What is the purpose of the change

Remove random genesis state from module API, and demo this change for other people doing something on the SDK

Brief Changelog

  • Rename and move GenerateGenesisState to a new extension interface, under better name RandomGenesisState.

(We still need to come back and unscrew up all the genesis handling, but this is a nice step in the direction)

Testing and Verifying

FullAppSimulation still making lockup module messages succesfully. Checked via local execution.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? yes
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? code comment

@ValarDragon ValarDragon requested review from czarcas7ic and a team July 15, 2022 04:33
@github-actions github-actions bot added C:app-wiring Changes to the app folder C:simulator Edits simulator or simulations C:x/gamm Changes, features and bugs related to the gamm module. C:x/lockup labels Jul 15, 2022
@ValarDragon ValarDragon mentioned this pull request Jul 15, 2022
Closed
4 tasks
czarcas7ic
czarcas7ic approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

simulation/types/manager.go
Actions() []Action
// PropertyTests()
}

type AppModuleSimulationV2WithRandGenesis interface {
AppModuleSimulationV2
// TODO: Come back and improve SimulationState interface
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you describe the desired endstate for what an improved SimulationState interface would look like?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a clear end state in mind yet, just its blatant that whats in the legacy thing is very bad / needs to be rethought

@ValarDragon ValarDragon merged commit 90d6dd1 into main Jul 15, 2022
@ValarDragon ValarDragon deleted the dev/simulator_remove_rand_genesis_from_default branch July 15, 2022 16:53
p0mvn pushed a commit that referenced this pull request Jul 18, 2022
@ValarDragon @p0mvn
Move random genesis to an extension interface (#2081)
c839742
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czarcas7ic czarcas7ic czarcas7ic approved these changes

Assignees
No one assigned
Labels
C:app-wiring Changes to the app folder C:simulator Edits simulator or simulations C:x/gamm Changes, features and bugs related to the gamm module. C:x/lockup
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ValarDragon @czarcas7ic