error returning epoch hooks #2526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:x/epochs
C:x/incentives
C:x/mint
C:x/superfluid
C:x/twap
puneet2019
changed the title
Merged
puneet2019
force-pushed
the
puneet/error-returning-epoch-hooks
branch
from
c5e4efe
to
8cca90c
Compare
ValarDragon
reviewed
Aug 29, 2022
x/epochs/keeper/hooks.go
Outdated
Comment on lines
8
to
14
| func (k Keeper) AfterEpochEnd(ctx sdk.Context, identifier string, epochNumber int64) { | ||
| k.hooks.AfterEpochEnd(ctx, identifier, epochNumber) | ||
| func (k Keeper) AfterEpochEnd(ctx sdk.Context, identifier string, epochNumber int64) error { | ||
| return k.hooks.AfterEpochEnd(ctx, identifier, epochNumber) | ||
| } | ||
|
|
||
| // BeforeEpochStart new epoch is next block of epoch end block | ||
| func (k Keeper) BeforeEpochStart(ctx sdk.Context, identifier string, epochNumber int64) { | ||
| k.hooks.BeforeEpochStart(ctx, identifier, epochNumber) |
There was a problem hiding this comment.
Can we ignore the error in here, instead of in abci.go?
ValarDragon
reviewed
Aug 29, 2022
x/mint/keeper/hooks_test.go
Outdated
| @@ -395,7 +395,10 @@ func (suite *KeeperTestSuite) TestAfterEpochEnd() { | |||
|
|
|||
| osmoassert.ConditionalPanic(suite.T(), tc.expectedPanic, func() { | |||
There was a problem hiding this comment.
We should change the variable here to expectedError, and then just do an if statement for checking if error vs checking no error
ValarDragon
approved these changes
Aug 29, 2022
p0mvn
approved these changes
Aug 29, 2022
p0mvn
approved these changes
Aug 30, 2022
There was a problem hiding this comment.
All suggestions have been applied. Should be ready for merge. Thanks @puneet2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
A part of #2520 only implemented for epochs module.
If it looks good, can go ahead and implement for other modules as well.
would wait for #2519 to be merged before. (rebase, etc. then open up)
What is the purpose of the change
ApplyFuncIfNoErrorhooks interfacefunctions to return an error.EpochHooks interfaceBrief Changelog
Testing and Verifying
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? (yes / no) yes