-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow state exporting from any directory #3608
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
added
A:backport/v12.x
backport patches to v12.x branch
V:state/compatible/backport
State machine compatible PR, should be backported
A:backport/v13.x
backport patches to v13.x branch
labels
Dec 3, 2022
czarcas7ic
approved these changes
Dec 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one less silly bug to worry about :)
mergify bot
pushed a commit
that referenced
this pull request
Dec 4, 2022
* Allow exporting from any directory * Changelog (cherry picked from commit da4f503) # Conflicts: # CHANGELOG.md # app/export.go
mergify bot
pushed a commit
that referenced
this pull request
Dec 4, 2022
* Allow exporting from any directory * Changelog (cherry picked from commit da4f503)
czarcas7ic
pushed a commit
that referenced
this pull request
Dec 5, 2022
ValarDragon
added a commit
that referenced
this pull request
Dec 6, 2022
* Allow state exporting from any directory (#3608) * Allow exporting from any directory * Changelog (cherry picked from commit da4f503) # Conflicts: # CHANGELOG.md # app/export.go * Fix conflicts Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Dev Ojha <dojha@berkeley.edu>
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A:backport/v12.x
backport patches to v12.x branch
A:backport/v13.x
backport patches to v13.x branch
C:app-wiring
Changes to the app folder
V:state/compatible/backport
State machine compatible PR, should be backported
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fixes the bug that prevents you from state exporting outside of the
.osmosisd
directory.Driveby deletes the unused "zeroForOne" export code as well.
Testing and Verifying
Tested manually
Documentation and Release Note
Unreleased
section inCHANGELOG.md
? yes