Add uosmo, uion denom metadata #4250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
reviewed
Feb 8, 2023
ValarDragon
reviewed
Feb 8, 2023
ValarDragon
reviewed
Feb 8, 2023
Comment on lines
+68
to
+80
| { | ||
| Denom: appParams.BaseCoinUnit, | ||
| Exponent: 0, | ||
| Aliases: nil, | ||
| }, | ||
| { | ||
| Denom: appParams.HumanCoinUnit, | ||
| Exponent: appParams.OsmoExponent, | ||
| Aliases: nil, | ||
| }, | ||
| }, | ||
| Base: appParams.BaseCoinUnit, | ||
| Display: appParams.HumanCoinUnit, |
There was a problem hiding this comment.
Confirmed that these AppParams are const's, so no need to worry about anything in build editing them
mattverse
reviewed
Feb 8, 2023
There was a problem hiding this comment.
LGTM once @ValarDragon 's testing recommendation has been added
mattverse
reviewed
Feb 8, 2023
|
addressed all comments! |
ValarDragon
reviewed
Feb 9, 2023
Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>
mergify bot
pushed a commit
that referenced
this pull request
Feb 9, 2023
* added metadata * added tests for metadata * matt and dev feedback * Apply suggestions from code review Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com> --------- Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com> (cherry picked from commit 34a0046)
ValarDragon
pushed a commit
that referenced
this pull request
Feb 9, 2023
* added metadata * added tests for metadata * matt and dev feedback * Apply suggestions from code review Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com> --------- Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com> (cherry picked from commit 34a0046) Co-authored-by: Sishir Giri <sis1001@berkeley.edu>
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4224
What is the purpose of the change
Add denom metadata for uosmo, uion
Brief Changelog
Testing and Verifying
tested in upgrade handler
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? (yes / no)x/<module>/spec/) / Osmosis docs repo / not documented)