Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently generate build tags metadata #4582

Merged
merged 1 commit into from
Mar 13, 2023

Commits on Mar 12, 2023

  1. Consistently generate build tags metadata

    Dockerfile receives a minor tweak for proper output.
    
    BuildTags value is expected as a plain `netgo,ledger,muslc` string,
    however the current approach wraps quotes inside of quotes, and the
    resulting string is `'netgo,ledger,muslc'` which gets escaped a
    few more times (unnecessarily).
    
    Additionally, Makefile receives a minor tweak for everyone who
    builds directly.
    
    With Make 4.3+, the empty whitespace does not seem to work as
    originally intended. This causes build tags to be `netgo ledger,`
    on Ubuntu 22.04 and other systems that include the newer Make
    version. The build tags were intended as `netgo,ledger` which
    can be observed on Make 4.2 (shipped with Ubuntu 20.04).
    
    This change swaps out the `+=` use in favor of an explicit `:=`.
    Ref: https://www.gnu.org/software/make/manual/html_node/Appending.html
    
    Upstream: cosmos/gaia@297cdb9
    sigv committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    9687891 View commit details
    Browse the repository at this point in the history