feat(ProtoRev): Support for CW Pools #5901
Conversation
davidterpay
added
protorev
|
@NotJeremyLiu @p0mvn @czarcas7ic added some tasks to #5858 for better CW testing. |
| @@ -20,6 +20,10 @@ var ( | |||
| StableWeight: 5, // it takes around 5 ms to simulate and execute a stable swap | |||
| BalancerWeight: 2, // it takes around 2 ms to simulate and execute a balancer swap | |||
| ConcentratedWeight: 2, // it takes around 2 ms to simulate and execute a concentrated swap | |||
There was a problem hiding this comment.
Since in upgrade we are resetting pool weights to the defaults, can we match the defaults to what's on mainnet today? (BalancerWeight is 1, ConcentratedWeight is 300 -- essentially turning it off)
There was a problem hiding this comment.
The CL issue should go away in the upgrade right?
There was a problem hiding this comment.
Yes! There is an outstanding task (which we will open a PR for in the next few days) that will bound protorev search better for CL pools and allow it to work on mainnet.
There was a problem hiding this comment.
I'll update the pool weights in the update PR.
There was a problem hiding this comment.
@ValarDragon Yeah the issue will go away, but I'd like to change the pool points in the PR that makes the issue go away rather than in this PR
| // The weight of a cosmwasm pool | ||
| uint64 cosmwasm_weight = 4 [ (gogoproto.moretags) = "yaml:\"cw_weight\"" ]; |
There was a problem hiding this comment.
We may need to make this dynamic based on address in the future?
I guess gas metering may also handle this for us?
(I'm in support of merging this, and discussing in an issue / spec doc)
There was a problem hiding this comment.
Yea totally agree. Ill add some tasks to the ProtoRev v17 issue tracker.
|
Awesome, thanks! |
* init * add new pool weights to upgrade handler * change log * add todo for genesis testing * proto ci * val basic testing * e2e test * main update * nit
What is the purpose of the change
This PR adds support for CW pools, primarily by adding it as a recognized type when calculating the amount of pool points a route consumes.
Related issue: #5858
Testing and Verifying