Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(math): add mutative api for BigDec.BigInt() #6993

Merged
merged 9 commits into from
Dec 7, 2023

Conversation

DongLieu
Copy link
Contributor

@DongLieu DongLieu commented Dec 4, 2023

Similar to cosmos/cosmos-sdk#17803 I think we should also have such an API

Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattverse
Copy link
Member

@DongLieu Can you add changelog entry for this?

@DongLieu
Copy link
Contributor Author

DongLieu commented Dec 4, 2023

Ok

@mattverse mattverse added the V:state/compatible/no_backport State machine compatible PR, depends on prior breaks label Dec 4, 2023
@mattverse mattverse self-assigned this Dec 4, 2023
Copy link
Member

@pysel pysel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mattverse
Copy link
Member

Leaving this 1 more day to see if anyone wants extra review, merging this in trmw

@DongLieu
Copy link
Contributor Author

DongLieu commented Dec 5, 2023

Ok, thanks you

@mattverse mattverse merged commit be79c76 into osmosis-labs:main Dec 7, 2023
1 check passed
@github-actions github-actions bot mentioned this pull request Mar 15, 2024
@github-actions github-actions bot mentioned this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants