Speedup CL spot price check and swap by removing an iterator #7258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
requested review from
czarcas7ic,
p0mvn and
AlpinYukseloglu
as code owners
p0mvn
approved these changes
Jan 7, 2024
There was a problem hiding this comment.
LGTM!
Confirmed that this is valid per:
- pool creation with no positions:
osmosis/x/concentrated-liquidity/model/pool.go
Lines 46 to 47 in 74ea7f1
- removal of last position:
osmosis/x/concentrated-liquidity/lp.go
Lines 615 to 616 in 74ea7f1
| // the current sqrt price being 0. | ||
| // We also check that the current tick is 0, which is also guaranteed in this situation. | ||
| // That derisks any edge-case where the sqrt price is 0 but the tick is not 0. | ||
| func (k Keeper) PoolHasPosition(ctx sdk.Context, pool types.ConcentratedPoolExtension) bool { |
There was a problem hiding this comment.
Would it be appropriate to define this method on the pool itself?
There was a problem hiding this comment.
Actually on further thought I'm not sure, this is a convention set by the keeper not the pool itself. (Adding a position doesn't go through a pool.AddPosition method)
Co-authored-by: Roman <roman@osmosis.team>
PaddyMc
approved these changes
Jan 7, 2024
czarcas7ic
approved these changes
Jan 7, 2024
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speedup the CL check for if a pool is initialized.
Right now we do a very expensive iterator call. This technically saves gas for user swaps, but this is really small (at not all commensurate with the CPU costs it induces)
More pressingly, this is a notable delay to block processing time, due to occurrence in:
Notice that SpotPrice is 0 iff there is no position in the pool. You can convince yourself of this by looking at: