feat: update node version BREAKING CHANGE (#184)

* feat: update node version BREAKING CHANGE * removing faker --------- Co-authored-by: Felix Menzel <Felix.Menzel.Dev@gmail.com>
ospin-web-dev · Feb 12, 2024 · ae04f6c · ae04f6c
1 parent c564346
commit ae04f6c
Show file tree

Hide file tree

Showing 8 changed files with 7,629 additions and 5,691 deletions.
diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-16.15
+20.11
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -6,7 +6,7 @@
   "main": "index.js",
   "license": "GPL-3.0-or-later",
   "engines": {
-    "node": "16.x",
+    "node": ">=20.x",
     "npm": ">=6"
   },
   "np": {
@@ -39,17 +39,17 @@
     "uuid": "^8.3.2"
   },
   "devDependencies": {
-    "@semantic-release/changelog": "^6.0.1",
+    "@faker-js/faker": "^8.4.1",
+    "@semantic-release/changelog": "^6.0.3",
     "@semantic-release/git": "^10.0.1",
-    "eslint": "^8.14.0",
+    "eslint": "^8.56.0",
     "eslint-config-airbnb-base": "^15.0.0",
-    "eslint-plugin-import": "^2.26.0",
-    "eslint-plugin-jest": "^26.1.5",
+    "eslint-plugin-import": "^2.29.1",
+    "eslint-plugin-jest": "^27.6.1",
     "eslint-plugin-jest-formatting": "^3.1.0",
-    "eslint-plugin-jsdoc": "^39.2.9",
-    "faker": "^5.5.3",
-    "jest": "^28.0.3",
-    "semantic-release": "^19.0.2"
+    "eslint-plugin-jsdoc": "^48.0.6",
+    "jest": "^29.7.0",
+    "semantic-release": "^23.0.2"
   },
   "jest": {
     "coverageDirectory": "./coverage/",

diff --git a/test/dataStreams/DataStream.test.js b/test/dataStreams/DataStream.test.js
@@ -1,15 +1,15 @@
-const faker = require('faker')
+const { faker } = require('@faker-js/faker')
 const DataStream = require('dataStreams/DataStream')
 
 describe('DataStream', () => {
   describe('create', () => {
     it('sets the default values accordingly', () => {
       const data = {
-        id: faker.datatype.uuid(),
-        sourceFctId: faker.datatype.uuid(),
-        sourceSlotName: faker.random.word(),
-        sinkFctId: faker.datatype.uuid(),
-        sinkSlotName: faker.random.word(),
+        id: faker.string.uuid(),
+        sourceFctId: faker.string.uuid(),
+        sourceSlotName: faker.lorem.word(),
+        sinkFctId: faker.string.uuid(),
+        sinkSlotName: faker.lorem.word(),
       }
 
       const dataStream = DataStream.create(data)

diff --git a/test/fctGraph/FCTGraph.test.js b/test/fctGraph/FCTGraph.test.js
@@ -1,4 +1,4 @@
-const faker = require('faker')
+const { faker } = require('@faker-js/faker')
 
 const FCTGraph = require('../../src/fctGraph/FCTGraph')
 const Slot = require('../../src/slots/Slot')
@@ -14,9 +14,9 @@ describe('FCTGraph', () => {
   describe('create', () => {
     it('sets all default values', () => {
       const data = {
-        id: faker.datatype.uuid(),
-        deviceId: faker.datatype.uuid(),
-        name: faker.random.word(),
+        id: faker.string.uuid(),
+        deviceId: faker.string.uuid(),
+        name: faker.lorem.word(),
       }
 
       const res = FCTGraph.create(data)
@@ -287,10 +287,10 @@ describe('FCTGraph', () => {
           'when generating a $name and connecting it to a any_number slot',
           ({ inSlotGenerator, outSlotGenerator }) => {
             it('does NOT throw an error', () => {
-              const slotA1 = inSlotGenerator()
-              const slotA2 = SlotSeeder.generateNumberOutSlot()
-              const slotB1 = outSlotGenerator()
-              const slotB2 = SlotSeeder.generateNumberInSlot()
+              const slotA1 = inSlotGenerator({name: 'slotA1'})
+              const slotA2 = SlotSeeder.generateNumberOutSlot({name: 'slotA2'})
+              const slotB1 = outSlotGenerator({name: 'slotB'})
+              const slotB2 = SlotSeeder.generateNumberInSlot({name: 'slotB2'})
 
               const fct1 = FunctionalitySeeder.generate({ slots: [ slotA1, slotB1 ] })
               const fct2 = FunctionalitySeeder.generate({ slots: [ slotA2, slotB2 ] })
@@ -369,7 +369,7 @@ describe('FCTGraph', () => {
         it('sets the publishIntervalMs to mirror the outputIntervalMs', () => {
           const intervalOut = FunctionalitySeeder.generateIntervalOut()
           const slot = SlotSeeder.generateFloatOutSlot()
-          const outputIntervalMs = faker.datatype.number()
+          const outputIntervalMs = faker.number.int()
           const fct = FunctionalitySeeder.generate({
             slots: [ slot ],
             outputIntervalMs,

diff --git a/test/functionalities/Functionality.test.js b/test/functionalities/Functionality.test.js
@@ -1,4 +1,4 @@
-const faker = require('faker')
+const { faker } = require('@faker-js/faker')
 const Functionality = require('../../src/functionalities/Functionality')
 const FunctionalitySeeder = require('../../src/seeders/functionalities/FunctionalitySeeder')
 const SlotSeeder = require('../../src/seeders/slots/SlotSeeder')
@@ -9,10 +9,10 @@ describe('Functionality', () => {
   describe('create', () => {
 
     const generateMinimalDataSet = () => ({
-      id: faker.datatype.uuid(),
-      name: faker.random.word(),
-      type: faker.random.word(),
-      subType: faker.random.word(),
+      id: faker.string.uuid(),
+      name: faker.lorem.word(),
+      type: faker.lorem.word(),
+      subType: faker.lorem.word(),
     })
 
     it('sets all default values', () => {
@@ -35,9 +35,9 @@ describe('Functionality', () => {
 
     it('allows setting optional values', () => {
       const optional = {
-        outputIntervalMs: faker.datatype.number({ min: 0 }),
+        outputIntervalMs: faker.number.int({ min: 0 }),
         ports: [
-          { name: faker.random.word(), purpose: faker.random.word() },
+          { name: faker.lorem.word(), purpose: faker.lorem.word() },
         ],
         posId: 1,
       }
@@ -66,7 +66,7 @@ describe('Functionality', () => {
         const nodeSpecific = {
           type: Functionality.FIXED_TYPES.OUTPUT_NODE,
           subType: Functionality.FIXED_SUB_TYPES.INTERVAL_OUT,
-          publishIntervalMs: faker.datatype.number({ min: 1, max: 1000 * 60 * 60 * 24 }),
+          publishIntervalMs: faker.number.int({ min: 1, max: 1000 * 60 * 60 * 24 }),
         }
 
         const res = Functionality.create({ ...generateMinimalDataSet(), ...nodeSpecific })
@@ -78,7 +78,7 @@ describe('Functionality', () => {
     describe('when NOT creating an INTERVAL_OUT node', () => {
       it('throw an error when try to set "publishIntervalMs"', () => {
         const nodeSpecific = {
-          publishIntervalMs: faker.datatype.number({ min: 1, max: 1000 * 60 * 60 * 24 }),
+          publishIntervalMs: faker.number.int({ min: 1, max: 1000 * 60 * 60 * 24 }),
         }
 
         expect(() => Functionality.create({ ...generateMinimalDataSet(), ...nodeSpecific }))
@@ -259,7 +259,7 @@ describe('Functionality', () => {
   describe('when working with connected fcts', () => {
 
     const creatDefaultSetup = () => {
-      const fctId = faker.datatype.uuid()
+      const fctId = faker.string.uuid()
       const ds1 = DataStreamSeeder.generate({ sinkSlotName: 'slotA', sinkFctId: fctId })
       const ds2 = DataStreamSeeder.generate({ sourceSlotName: 'slotB', sourceFctId: fctId })
       const slotA = SlotSeeder
@@ -341,7 +341,7 @@ describe('Functionality', () => {
         it('should return false', () => {
           const { fct } = creatDefaultSetup()
 
-          const res = Functionality.isConnectedToFct(fct, faker.datatype.uuid)
+          const res = Functionality.isConnectedToFct(fct, faker.string.uuid)
 
           expect(res).toBe(false)
         })

diff --git a/test/slots/Slot.test.js b/test/slots/Slot.test.js
@@ -1,4 +1,4 @@
-const faker = require('faker')
+const { faker } = require('@faker-js/faker')
 
 const Slot = require('../../src/slots/Slot')
 const DataStreamSeeder = require('../../src/seeders/dataStreams/DataStreamSeeder')
@@ -10,7 +10,7 @@ describe('Slot', () => {
     describe('when creating an "integer" slot', () => {
 
       const generateDefaultData = (data = {}) => ({
-        name: faker.random.word(),
+        name: faker.lorem.word(),
         type: Slot.TYPES.IN_SLOT,
         dataType: Slot.DATA_TYPES.INTEGER,
         unit: '-',
@@ -61,7 +61,7 @@ describe('Slot', () => {
     describe('when creating a "float" slot', () => {
 
       const generateDefaultData = (data = {}) => ({
-        name: faker.random.word(),
+        name: faker.lorem.word(),
         type: Slot.TYPES.IN_SLOT,
         dataType: Slot.DATA_TYPES.FLOAT,
         unit: '-',
@@ -112,7 +112,7 @@ describe('Slot', () => {
     describe('when creating a "boolean" slot', () => {
 
       const generateDefaultData = (data = {}) => ({
-        name: faker.random.word(),
+        name: faker.lorem.word(),
         type: Slot.TYPES.IN_SLOT,
         dataType: Slot.DATA_TYPES.BOOLEAN,
         unit: '-',
@@ -146,7 +146,7 @@ describe('Slot', () => {
     describe('when creating an "oneOf" slot', () => {
 
       const generateDefaultData = (data = {}) => ({
-        name: faker.random.word(),
+        name: faker.lorem.word(),
         type: Slot.TYPES.IN_SLOT,
         dataType: Slot.DATA_TYPES.ONE_OF,
         unit: '-',
@@ -187,7 +187,7 @@ describe('Slot', () => {
       'when creating a %p slot',
       (type) => {
         const generateDefaultData = (data = {}) => ({
-          name: faker.random.word(),
+          name: faker.lorem.word(),
           type: Slot.TYPES.IN_SLOT,
           dataType: type,
           unit: '-',
@@ -332,7 +332,7 @@ describe('Slot', () => {
       it('returns false', () => {
         const slot = SlotSeeder.generateIntegerInSlot()
 
-        const res = Slot.connectsToFctSlot(slot, faker.datatype.uuid(), faker.random.word())
+        const res = Slot.connectsToFctSlot(slot, faker.string.uuid(), faker.lorem.word())
 
         expect(res).toBe(false)
       })

diff --git a/test/utils/RandomDataGenerator.test.js b/test/utils/RandomDataGenerator.test.js
@@ -1,5 +1,5 @@
 /* eslint no-plusplus: ["error", { "allowForLoopAfterthoughts": true }] */
-const faker = require('faker')
+const { faker } = require('@faker-js/faker')
 const RandomDataGenerator = require('../../src/utils/RandomDataGenerator')
 const RegexUtils = require('../../src/utils/RegexUtils')
 
@@ -35,8 +35,8 @@ describe('the RandomDataGenerator', () => {
     describe('when given a min and max', () => {
       it('should generate numbers between those', () => {
         for (let index = 0; index < numberOfTestRuns; index++) {
-          const min = faker.datatype.number()
-          const max = faker.datatype.number() + min
+          const min = faker.number.int()
+          const max = faker.number.int() + min
           const generatedNumber = RandomDataGenerator.integer({ min, max })
           expect(generatedNumber <= max).toBe(true)
           expect(generatedNumber >= min).toBe(true)
@@ -58,8 +58,8 @@ describe('the RandomDataGenerator', () => {
     describe('when given a min and max', () => {
       it('should generate numbers between those', () => {
         for (let index = 0; index < numberOfTestRuns; index++) {
-          const min = faker.datatype.number()
-          const max = faker.datatype.number() + min
+          const min = faker.number.int()
+          const max = faker.number.int() + min
           const generatedNumber = RandomDataGenerator.float({ min, max })
           expect(generatedNumber <= max).toBe(true)
           expect(generatedNumber >= min).toBe(true)